fix scrolled() signal in WTableView

Author: Koen Deforche

src/Wt/WAbstractItemView

@@ -779,6 +779,12 @@ public:
    */
   Signal<int, WMouseEvent> &headerDoubleClicked() { return headerDblClicked_; }
 
+  /*! \brief Signals when scrolling.
+   *
+   *  \note Works only if ajax is available.
+   */
+  virtual EventSignal<WScrollEvent>& scrolled() = 0;
+
   /*! \brief Configures the number of columns that are used as row
    *         headers.
    *
@@ -888,6 +894,7 @@ protected:
    */
   virtual WWidget *createPageNavigationBar();
 
+
 protected:
   struct ColumnInfo {
     WCssTemplateRule *styleRule;

src/Wt/WTableView

@@ -106,11 +106,7 @@ public:
 
   WModelIndex modelIndexAt(WWidget *widget) const;
 
-  /*! \brief Signals when scrolling.
-   *
-   *  \note Works only if ajax is available.
-   */
-  EventSignal<WScrollEvent>& scrolled();
+  virtual EventSignal<WScrollEvent>& scrolled();
 
  protected:
   virtual void render(WFlags<RenderFlag> flags);

src/Wt/WTableView.C

@@ -166,6 +166,8 @@ WTableView::WTableView(WContainerWidget *parent)
        "if (obj) obj.autoJavaScript();}");
 
     connectObjJS(canvas_->mouseWentDown(), "mouseDown");
+    connectObjJS(contentsContainer_->scrolled(),
+                 "onContentsContainerScroll");
   } else {
     plainTable_ = new WTable();
     plainTable_->setStyleClass("Wt-plaintable");

src/Wt/WTreeView

@@ -247,6 +247,7 @@ public:
 
   virtual void scrollTo(const WModelIndex& index,
 			ScrollHint hint = EnsureVisible);
+  virtual EventSignal<WScrollEvent>& scrolled();
 
 protected:
   virtual void render(WFlags<RenderFlag> flags);

src/Wt/WTreeView.C

@@ -2791,6 +2791,12 @@ void WTreeView::scrollTo(const WModelIndex& index, ScrollHint hint)
     setCurrentPage(row / pageSize());
 }
 
+EventSignal<WScrollEvent>& WTreeView::scrolled(){
+  if (wApp->environment().ajax() && contentsContainer_ != 0)
+    return contentsContainer_->scrolled();
+
+  throw WException("Scrolled signal existes only with ajax.");
+}
 }
 
 #endif // DOXYGEN_ONLY

src/http/WtReply.C

@@ -174,7 +174,15 @@ void WtReply::consumeRequestBody(Buffer::const_iterator begin,
 	in_->seekg(0); // rewind
 
 	// Note: cannot be wrapped in the strand because then we get into
-	// trouble with recursive event loop?
+	// trouble with recursive event loop
+	// 
+	// Are we sure that the reply object isn't deleted before it's used?
+	// the httpRequest_ has a WtReplyPtr and httpRequest_ is only deleted
+	// from the destructor, so that's okay.
+	//
+	// The WtReplyPtr is reset in HTTPRequest::flush(Done), could that
+	// be called already? No because nobody is aware yet of this request
+	// object.
 	connection->server()->service().post
 	  (boost::bind(&Wt::WebController::handleRequest,
 		       connection->server()->controller(),

src/js/WTableView.js

@@ -28,7 +28,7 @@ WT_DECLARE_WT_MEMBER
     */
    var scrollTop = 0, scrollLeft = 0, currentWidth = 0, currentHeight = 0;
 
-   contentsContainer.onscroll = function() {
+   this.onContentsContainerScroll = function() {
      scrollLeft = headerContainer.scrollLeft
 		   = contentsContainer.scrollLeft;
      scrollTop = headerColumnsContainer.scrollTop