Executable hooks must actually be executable

Author: ess

features/hook/running-a-deploy-hook.feature

@@ -198,10 +198,37 @@ Feature: Running A Deploy Hook
       | before_restart        |
       | after_restart         |
       | after_deploy          |
-  #Scenario: Running a callback with both service hooks and deploy hooks
+
+
+  Scenario Outline: Executable hooks without the executable bit get skipped
+    Given my app has a <Callback Name> executable deploy hook
+    But my app's <Callback Name> executable deploy hook is not actually executable
+    And I have a service named selective
+    Given my service has a <Callback Name> executable hook
+    When I run the <Callback Name> callback
+    Then the <Callback Name> executable hook for my service is executed
+    But the <Callback Name> executable deploy hook is not executed
+
+    Examples:
+      | Callback Name         |
+      | before_deploy         |
+      | before_bundle         |
+      | after_bundle          |
+      | before_compile_assets |
+      | after_compile_assets  |
+      | before_migrate        |
+      | after_migrate         |
+      | before_symlink        |
+      | after_symlink         |
+      | before_restart        |
+      | after_restart         |
+      | after_deploy          |
 
     #@failure
   #Scenario: Ruby hooks with syntax errors cause an error
 
+    #@failure
+  #Scenario: Ruby hook errors cause an error
+
     #@failure
   #Scenario: Executable hooks that are not actually executable cause an error

features/hook/step_definitions/running-a-deploy-hook-steps.rb

@@ -140,6 +140,12 @@ def service_name
     to eql(false)
 end
 
+Given %r{^my app's (.+) executable deploy hook is not actually executable$} do |callback_name|
+  hook = deploy_hooks_path.join(callback_name)
+
+  hook.chmod(0644)
+end
+
 Then %{I see the output} do
   puts "OUTPUT START\n\n#{output_text}\n\nOUTPUT END"
 end