chore : add MODULE.bazel with bzlmod dependency management#632
Conversation
mmorel-35
force-pushed
the
bzlmod
branch
6 times, most recently
from
7a93928 to
4a35257
Compare
|
@phlax , According to the logs it needs Java, https://app.circleci.com/pipelines/github/envoyproxy/data-plane-api/1813/workflows/0c1784ea-dfd3-44bc-a9e6-474d123886a9/jobs/7498 shall it be added with a bazel dep or is it something that must be installed in the Image ? |
|
as a bazel dep - im desperately trying to get rid of anything non-hermetic that remains |
…el file (#41835) #### Description This PR apply necessary changes for envoy_api MODULE without MODULE.bazel file. cf. envoyproxy/data-plane-api#632 Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
…el file (#41835) #### Description This PR apply necessary changes for envoy_api MODULE without MODULE.bazel file. cf. #632 Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Mirrored from https://github.com/envoyproxy/envoy @ 78cff0755120fdf87b5e06eb3cf7d283866a6d9b
mmorel-35
force-pushed
the
bzlmod
branch
3 times, most recently
from
034a23b to
f9792ef
Compare
|
@phlax , I know this is a read only project, but can this be integrated here anyway or shall it be only persisted in envoy ? |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
|
@phlax , Shall this be merged so at least circleci passes correctly ? |
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
happy to land it with caveat that maintenance status is uncertain here
lgtm, thanks @mmorel-35
…el file (envoyproxy#41835) #### Description This PR apply necessary changes for envoy_api MODULE without MODULE.bazel file. cf. envoyproxy/data-plane-api#632 Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
2 participants
Description
This is a draft to be able to validate what needs to be done without being in envoy project.