Skip to content

Commit c9ccdca

Browse files
author
alan.cl
committed
fix: create benchmark task first
1 parent 7b228ce commit c9ccdca

File tree

2 files changed

+17
-15
lines changed

2 files changed

+17
-15
lines changed

packages/dbgpt-serve/src/dbgpt_serve/evaluate/service/benchmark/benchmark_service.py

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -252,17 +252,6 @@ async def run_dataset_benchmark(
252252
if not scene_key:
253253
scene_key = EvaluationScene.DATASET.value
254254

255-
try:
256-
manager = get_benchmark_manager(self._system_app)
257-
await manager.load_data()
258-
logger.info(
259-
f"Benchmark dataset loaded from {manager._config.repo_url} "
260-
f"dir={manager._config.data_dir}"
261-
)
262-
except Exception as e:
263-
logger.error(f"Failed to load benchmark dataset before run: {e}")
264-
raise e
265-
266255
output_file_path = self._generate_output_file_full_path(
267256
output_file_path, evaluate_code
268257
)
@@ -282,6 +271,7 @@ async def run_dataset_benchmark(
282271
response_mapping,
283272
)
284273
logger.info(f"run benchmark with benchmarkConfig={config}")
274+
start_time = time.time()
285275

286276
# save benchmark task
287277
self.create_benchmark_task(
@@ -293,8 +283,23 @@ async def run_dataset_benchmark(
293283
output_file_path,
294284
)
295285

286+
# Priority: load Falcon github benchmark dataset
287+
try:
288+
manager = get_benchmark_manager(self._system_app)
289+
await manager.load_data()
290+
logger.info(
291+
f"Benchmark dataset loaded from {manager._config.repo_url} "
292+
f"dir={manager._config.data_dir}"
293+
)
294+
except Exception as e:
295+
logger.error(f"Failed to load Falcon benchmark dataset before run task: {e}")
296+
cost_time = int(time.time() - start_time)
297+
self._update_benchmark_task_status(
298+
evaluate_code, Status.FAILED.value, cost_time, error_message=str(e)
299+
)
300+
raise e
301+
296302
result_list = []
297-
start_time = time.time()
298303
try:
299304
# read input file
300305
input_list: List[BaseInputModel] = (

packages/dbgpt-serve/src/dbgpt_serve/evaluate/service/fetchdata/benchmark_data_manager.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,6 @@ def init_app(self, system_app: SystemApp):
7171
"""Initialize the AgentManager."""
7272
self.system_app = system_app
7373

74-
async def async_after_start(self):
75-
logger.info("BenchmarkDataManager: async_after_start.")
76-
7774
async def async_before_stop(self):
7875
try:
7976
logger.info("BenchmarkDataManager: closing resources before stop...")

0 commit comments

Comments
 (0)