Use osfamily fact for operating system specific config and packages to cover a wider range of distributions.

Author: erwbgy

manifests/config.pp

@@ -5,9 +5,6 @@
   $uris_space = join($uris, ' ')
   $uris_comma = join($uris, ',')
 
-  include "pamldap::config::$operatingsystem"
-}
-class pamldap::config::common {
   # defaults
   File {
     owner => 'root',
@@ -51,34 +48,31 @@
     require => Class['pamldap::install'],
     notify  => Class['pamldap::service'],
   }
-}
 
-class pamldap::config::redhat inherits pamldap::config::common {
-  file { '/etc/ldap.conf':
-    ensure  => present,
-    mode    => '0444',
-    content => template('pamldap/ldap.conf.erb'),
-    require => Class['pamldap::install'],
-    notify  => Class['pamldap::service'],
-  }
-  file { [ '/etc/pam_ldap.conf', '/etc/openldap/ldap.conf' ]:
-    ensure  => link,
-    target  => '/etc/ldap.conf',
-    require => File['/etc/ldap.conf'],
-    notify  => Class['pamldap::service'],
-  }
-}
-
-class pamldap::config::centos inherits pamldap::config::redhat {
-    # No changes
-}
-
-class pamldap::config::ubuntu inherits pamldap::config::common {
-  file { '/etc/ldap/ldap.conf':
-    ensure  => present,
-    mode    => '0444',
-    content => template('pamldap/ldap.conf.erb'),
-    require => Class['pamldap::install'],
-    notify  => Class['pamldap::service'],
+  case $::osfamily {
+    'RedHat': {
+      file { '/etc/ldap.conf':
+        ensure  => present,
+        mode    => '0444',
+        content => template('pamldap/ldap.conf.erb'),
+        require => Class['pamldap::install'],
+        notify  => Class['pamldap::service'],
+      }
+      file { [ '/etc/pam_ldap.conf', '/etc/openldap/ldap.conf' ]:
+        ensure  => link,
+        target  => '/etc/ldap.conf',
+        require => File['/etc/ldap.conf'],
+        notify  => Class['pamldap::service'],
+      }
+    }
+    'Debian': {
+      file { '/etc/ldap/ldap.conf':
+        ensure  => present,
+        mode    => '0444',
+        content => template('pamldap/ldap.conf.erb'),
+        require => Class['pamldap::install'],
+        notify  => Class['pamldap::service'],
+      }
+    }
   }
 }

manifests/install.pp

@@ -1,34 +1,26 @@
 class pamldap::install {
-  include "pamldap::install::$operatingsystem"
-}
-
-class pamldap::install::common {
   if ! defined(Package['sssd']) {
     package { 'sssd':  ensure => installed }
   }
-}
-
-class pamldap::install::redhat inherits pamldap::install::common {
-  if ! defined(Package['sssd-client']) {
-    package { 'sssd-client':  ensure => installed }
-  }
-  if ! defined(Package['openldap-clients']) {
-    package { 'openldap-clients':  ensure => installed }
+  case $::osfamily {
+    'Redhat': {
+      if ! defined(Package['sssd-client']) {
+        package { 'sssd-client':  ensure => installed }
+      }
+      if ! defined(Package['openldap-clients']) {
+        package { 'openldap-clients':  ensure => installed }
+      }
+    }
+    'Debian': {
+      if ! defined(Package['libnss-sss']) {
+        package { 'libnss-sss':  ensure => installed }
+      }
+      if ! defined(Package['libpam-sss']) {
+        package { 'libpam-sss':  ensure => installed }
+      }
+      if ! defined(Package['ldap-utils']) {
+        package { 'ldap-utils':  ensure => installed }
+      }
+    }
   }
 }
-
-class pamldap::install::centos inherits pamldap::install::redhat {
-    # No changes
-}
-
-class pamldap::install::ubuntu inherits pamldap::install::common {
-  if ! defined(Package['libnss-sss']) {
-    package { 'libnss-sss':  ensure => installed }
-  }
-  if ! defined(Package['libpam-sss']) {
-    package { 'libpam-sss':  ensure => installed }
-  }
-  if ! defined(Package['ldap-utils']) {
-    package { 'ldap-utils':  ensure => installed }
-  }
-}