Skip to content

Commit 42dd7ac

Browse files
Use anypb.New instead of ptypes.MarshalAny (grpc#6074)
1 parent 415ccdf commit 42dd7ac

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

channelz/service/func_linux.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import (
2525
durpb "github.com/golang/protobuf/ptypes/duration"
2626
channelzpb "google.golang.org/grpc/channelz/grpc_channelz_v1"
2727
"google.golang.org/grpc/internal/channelz"
28+
"google.golang.org/protobuf/types/known/anypb"
2829
)
2930

3031
func convertToPtypesDuration(sec int64, usec int64) *durpb.Duration {
@@ -34,7 +35,7 @@ func convertToPtypesDuration(sec int64, usec int64) *durpb.Duration {
3435
func sockoptToProto(skopts *channelz.SocketOptionData) []*channelzpb.SocketOption {
3536
var opts []*channelzpb.SocketOption
3637
if skopts.Linger != nil {
37-
additional, err := ptypes.MarshalAny(&channelzpb.SocketOptionLinger{
38+
additional, err := anypb.New(&channelzpb.SocketOptionLinger{
3839
Active: skopts.Linger.Onoff != 0,
3940
Duration: convertToPtypesDuration(int64(skopts.Linger.Linger), 0),
4041
})
@@ -48,7 +49,7 @@ func sockoptToProto(skopts *channelz.SocketOptionData) []*channelzpb.SocketOptio
4849
}
4950
}
5051
if skopts.RecvTimeout != nil {
51-
additional, err := ptypes.MarshalAny(&channelzpb.SocketOptionTimeout{
52+
additional, err := anypb.New(&channelzpb.SocketOptionTimeout{
5253
Duration: convertToPtypesDuration(int64(skopts.RecvTimeout.Sec), int64(skopts.RecvTimeout.Usec)),
5354
})
5455
if err == nil {
@@ -61,7 +62,7 @@ func sockoptToProto(skopts *channelz.SocketOptionData) []*channelzpb.SocketOptio
6162
}
6263
}
6364
if skopts.SendTimeout != nil {
64-
additional, err := ptypes.MarshalAny(&channelzpb.SocketOptionTimeout{
65+
additional, err := anypb.New(&channelzpb.SocketOptionTimeout{
6566
Duration: convertToPtypesDuration(int64(skopts.SendTimeout.Sec), int64(skopts.SendTimeout.Usec)),
6667
})
6768
if err == nil {
@@ -74,7 +75,7 @@ func sockoptToProto(skopts *channelz.SocketOptionData) []*channelzpb.SocketOptio
7475
}
7576
}
7677
if skopts.TCPInfo != nil {
77-
additional, err := ptypes.MarshalAny(&channelzpb.SocketOptionTcpInfo{
78+
additional, err := anypb.New(&channelzpb.SocketOptionTcpInfo{
7879
TcpiState: uint32(skopts.TCPInfo.State),
7980
TcpiCaState: uint32(skopts.TCPInfo.Ca_state),
8081
TcpiRetransmits: uint32(skopts.TCPInfo.Retransmits),

channelz/service/service.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,18 @@ import (
2525

2626
"github.com/golang/protobuf/ptypes"
2727
wrpb "github.com/golang/protobuf/ptypes/wrappers"
28-
"google.golang.org/grpc"
2928
channelzgrpc "google.golang.org/grpc/channelz/grpc_channelz_v1"
3029
channelzpb "google.golang.org/grpc/channelz/grpc_channelz_v1"
30+
31+
"google.golang.org/grpc"
3132
"google.golang.org/grpc/codes"
3233
"google.golang.org/grpc/connectivity"
3334
"google.golang.org/grpc/credentials"
3435
"google.golang.org/grpc/grpclog"
3536
"google.golang.org/grpc/internal/channelz"
3637
"google.golang.org/grpc/status"
38+
"google.golang.org/protobuf/protoadapt"
39+
"google.golang.org/protobuf/types/known/anypb"
3740
)
3841

3942
func init() {
@@ -187,7 +190,7 @@ func securityToProto(se credentials.ChannelzSecurityValue) *channelzpb.Security
187190
otherSecurity := &channelzpb.Security_OtherSecurity{
188191
Name: v.Name,
189192
}
190-
if anyval, err := ptypes.MarshalAny(v.Value); err == nil {
193+
if anyval, err := anypb.New(protoadapt.MessageV2Of(v.Value)); err == nil {
191194
otherSecurity.Value = anyval
192195
}
193196
return &channelzpb.Security{Model: &channelzpb.Security_Other{Other: otherSecurity}}

0 commit comments

Comments
 (0)