Fix wrap_range going out of bounds

max-arnold · max-arnold · commit 023b0c686ec6 · 2025-11-10T10:36:29.000+07:00
diff --git a/ats-mini/Menu.cpp b/ats-mini/Menu.cpp
@@ -475,7 +475,7 @@ static inline int min(int x, int y) { return(x<y? x:y); }
 static inline int wrap_range(int v, int enc, int vMin, int vMax)
 {
   v += enc;
-  v  = v>vMax? vMin + (v - vMax - 1) : v<vMin? vMax - (vMin - v - 1) : v;
+  v  = v>vMax? vMin + (v - vMax - 1) % (vMax - vMin + 1) : v<vMin? vMax - (vMin - v - 1) % (vMax - vMin + 1) : v;
   return(v);
 }
 
diff --git a/changelog/+menu-bounds.fixed.md b/changelog/+menu-bounds.fixed.md
@@ -0,0 +1 @@
+Fix out of range menu controls due to fast encoder rotation.

Original file line number	Diff line number	Diff line change
`@@ -475,7 +475,7 @@ static inline int min(int x, int y) { return(x<y? x:y); }`
`475`	`475`	`static inline int wrap_range(int v, int enc, int vMin, int vMax)`
`476`	`476`	`{`
`477`	`477`	`v += enc;`
`478`		`- v = v>vMax? vMin + (v - vMax - 1) : v<vMin? vMax - (vMin - v - 1) : v;`
	`478`	`+ v = v>vMax? vMin + (v - vMax - 1) % (vMax - vMin + 1) : v<vMin? vMax - (vMin - v - 1) % (vMax - vMin + 1) : v;`
`479`	`479`	`return(v);`
`480`	`480`	`}`
`481`	`481`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fix out of range menu controls due to fast encoder rotation.`