Add (hopefully) all UTC offsets

Author: max-arnold

ats-mini/Common.h

@@ -114,7 +114,6 @@ typedef struct
 {
   int8_t offset;          // UTC offset in 15 minute intervals
   const char *desc;       // Short description
-  const char *city;       // City name
 } UTCOffset;
 
 typedef struct

ats-mini/Menu.cpp

@@ -209,31 +209,52 @@ static const char *sleepModeDesc[] =
 
 //
 // UTC Offset Menu
-// FIXME: add more offsets https://en.wikipedia.org/wiki/List_of_UTC_offsets
+// https://en.wikipedia.org/wiki/List_of_UTC_offsets
+// https://www.timeanddate.com/time/time-zones-interesting.html
 //
 uint8_t utcOffsetIdx = 8;
 const UTCOffset utcOffsets[] =
 {
-  { -8 * 4, "UTC-8", "Fairbanks" },
-  { -7 * 4, "UTC-7", "San Francisco" },
-  { -6 * 4, "UTC-6", "Denver" },
-  { -5 * 4, "UTC-5", "Houston" },
-  { -4 * 4, "UTC-4", "New York" },
-  { -3 * 4, "UTC-3", "Rio de Janeiro" },
-  { -2 * 4, "UTC-2", "Sandwich Islands" },
-  { -1 * 4, "UTC-1", "Nuuk" },
-  {  0 * 4, "UTC+0", "Reykjavik" },
-  {  1 * 4, "UTC+1", "London" },
-  {  2 * 4, "UTC+2", "Berlin" },
-  {  3 * 4, "UTC+3", "Moscow" },
-  {  4 * 4, "UTC+4", "Yerevan" },
-  {  5 * 4, "UTC+5", "Astana" },
-  {  5 * 4 + 2, "UTC+5:30", "Kolkata" },
-  {  6 * 4, "UTC+6", "Omsk" },
-  {  7 * 4, "UTC+7", "Novosibirsk" },
-  {  8 * 4, "UTC+8", "Beijing" },
-  {  9 * 4, "UTC+9", "Yakutsk" },
-  { 10 * 4, "UTC+10", "Vladivostok" },
+  { -12 * 4, "UTC-12" },
+  { -11 * 4, "UTC-11" },
+  { -10 * 4, "UTC-10" },
+  { -9 * 4 - 2, "UTC-9:30" },
+  { -9 * 4, "UTC-9" },
+  { -8 * 4, "UTC-8" },
+  { -7 * 4, "UTC-7" },
+  { -6 * 4, "UTC-6" },
+  { -5 * 4, "UTC-5" },
+  { -4 * 4, "UTC-4" },
+  { -3 * 4 - 2, "UTC-3:30" },
+  { -3 * 4, "UTC-3" },
+  { -2 * 4 - 2, "UTC-2:30" },
+  { -2 * 4, "UTC-2" },
+  { -1 * 4, "UTC-1" },
+  {  0 * 4, "UTC+0" },
+  {  1 * 4, "UTC+1" },
+  {  2 * 4, "UTC+2" },
+  {  3 * 4, "UTC+3" },
+  {  3 * 4 + 2, "UTC+3:30" },
+  {  4 * 4, "UTC+4" },
+  {  4 * 4 + 2, "UTC+4:30" },
+  {  5 * 4, "UTC+5" },
+  {  5 * 4 + 2, "UTC+5:30" },
+  {  5 * 4 + 3, "UTC+5:45" },
+  {  6 * 4, "UTC+6" },
+  {  6 * 4 + 2, "UTC+6:30" },
+  {  7 * 4, "UTC+7" },
+  {  8 * 4, "UTC+8" },
+  {  8 * 4 + 3, "UTC+8:45" },
+  {  9 * 4, "UTC+9" },
+  {  9 * 4 + 2, "UTC+9:30" },
+  { 10 * 4, "UTC+10" },
+  { 10 * 4 + 2, "UTC+10:30" },
+  { 11 * 4, "UTC+11" },
+  { 12 * 4, "UTC+12" },
+  { 12 * 4 + 3, "UTC+12:45" },
+  { 13 * 4, "UTC+13" },
+  { 13 * 4 + 3, "UTC+13:45" },
+  { 14 * 4, "UTC+14" },
 };
 
 int getCurrentUTCOffset() { return(utcOffsets[utcOffsetIdx].offset); }

ats-mini/Network.cpp

@@ -488,9 +488,9 @@ static const String webUtcOffsetSelector()
     char text[64];
 
     sprintf(text,
-      "<OPTION VALUE='%d'%s>%s (%s)</OPTION>",
+      "<OPTION VALUE='%d'%s>%s</OPTION>",
       i, utcOffsetIdx==i? " SELECTED":"",
-      utcOffsets[i].city, utcOffsets[i].desc
+      utcOffsets[i].desc
     );
 
     result += text;

changelog/287.fixed.md

@@ -0,0 +1 @@
+Add an exhaustive (hopefully) list of UTC offsets. WARNING: please adjust your UTC offset again (the stored index is no longer valid).

docs/source/manual.md

@@ -69,7 +69,7 @@ The menu can be invoked by clicking the encoder button and is closed automatical
 * **Brightness** - Display brightness level (10...255). The minimal one draws about 80mA of the battery power, the default one about 100mA, the max level about 120mA.
 * **Calibration** - SSB calibration offset (-2000...2000, per mode/band).
 * **RDS** - Radio Data System options: PS - radio station name, CT - time, RT - text, PTY - genre, ALL (EU/US) - everything. Note that the time can be transmitted either in UTC or in local timezone, as well as be completely bogus. The clock is synchronized only once, so you can pick the right time source (switch the receiver power off and on to resync it again).
-* **UTC Offset** - Affects the displayed time, whether it was received via RDS or NTP.
+* **UTC Offset** - Affects the displayed time, whether it was received via RDS or NTP. Please note that automatic DST transitions are not supported, the offset needs to be adjusted manually.
 * **FM Region** - FM de-emphasis time constant by region (50µs for EU/JP/AU and 70µs for the US).
 * **Theme** - Color theme.
 * **UI Layout** - Alternative UI layouts. For now there is just one alternative UI with large S-meter and S/N-meter.