Remove tune holdoff feature

Author: max-arnold

ats-mini/Common.h

@@ -129,8 +129,6 @@ extern SI4735_fixed rx;
 extern TFT_eSprite spr;
 extern TFT_eSPI tft;
 
-extern bool tuning_flag;
-extern uint8_t tuneHoldOff;
 extern bool pushAndRotate;
 extern bool seekStop;
 extern uint8_t rssi;

ats-mini/Draw.cpp

@@ -426,9 +426,6 @@ void drawScreen(const char *statusLine1, const char *statusLine2)
 {
   if(sleepOn()) return;
 
-  // Do not update the screen while tuning (if enabled)
-  if(tuneHoldOff && tuning_flag) return;
-
   // Clear screen buffer
   spr.fillSprite(TH.bg);
 

ats-mini/Network.cpp

@@ -387,9 +387,8 @@ void webSetConfig(AsyncWebServerRequest *request)
     prefsSave |= SAVE_SETTINGS;
   }
 
-  // Save scroll direction, tuning hold off, and menu zoom
+  // Save scroll direction and menu zoom
   scrollDirection = request->hasParam("scroll", true)? -1 : 1;
-  tuneHoldOff     = request->getParam("holdoff", true)->value().toInt();
   zoomMenu        = request->hasParam("zoom", true);
   prefsSave |= SAVE_SETTINGS;
 
@@ -690,11 +689,6 @@ const String webConfigPage()
     "<TD CLASS='LABEL'>Reverse Scrolling</TD>"
     "<TD><INPUT TYPE='CHECKBOX' NAME='scroll' VALUE='on'" +
     (scrollDirection<0? " CHECKED ":"") + "></TD>"
-  "</TR>"
-  "<TR>"
-    "<TD CLASS='LABEL'>Tuning Display Delay</TD>"
-    "<TD><INPUT TYPE='NUMBER' NAME='holdoff' VALUE='" +
-tuneHoldOff + "' MIN='0' MAX='255'></TD>"
   "</TR>"
    "<TR>"
     "<TD CLASS='LABEL'>Zoomed Menu</TD>"

ats-mini/Storage.cpp

@@ -188,7 +188,6 @@ void prefsSave(uint32_t items)
     prefs.putUChar("SleepMode",   sleepModeIdx);   // Sleep mode
     prefs.putUChar("ZoomMenu",    zoomMenu);       // TRUE: Zoom menu
     prefs.putBool("ScrollDir", scrollDirection<0); // TRUE: Reverse scroll
-    prefs.putUChar("TuneHoldOff", tuneHoldOff);    // Tuning hold off
     prefs.putUChar("UTCOffset",   utcOffsetIdx);   // UTC Offset
     prefs.putUChar("Squelch",     currentSquelch); // Squelch
     prefs.putUChar("FmRegion",    FmRegionIdx);    // FM region
@@ -262,7 +261,6 @@ bool prefsLoad(uint32_t items)
     sleepModeIdx   = prefs.getUChar("SleepMode", sleepModeIdx); // Sleep mode
     zoomMenu       = prefs.getUChar("ZoomMenu", zoomMenu);      // TRUE: Zoom menu
     scrollDirection = prefs.getBool("ScrollDir", scrollDirection<0)? -1:1; // TRUE: Reverse scroll
-    tuneHoldOff    = prefs.getUChar("TuneHoldOff", tuneHoldOff); // Tuning hold off
     utcOffsetIdx   = prefs.getUChar("UTCOffset", utcOffsetIdx); // UTC Offset
     currentSquelch = prefs.getUChar("Squelch", currentSquelch); // Squelch
     FmRegionIdx    = prefs.getUChar("FmRegion", FmRegionIdx);   // FM region

ats-mini/ats-mini.ino

@@ -77,9 +77,6 @@ int8_t scrollDirection = 1;             // Menu scroll direction
 
 // Background screen refresh
 uint32_t background_timer = millis();   // Background screen refresh timer.
-uint32_t tuning_timer = millis();       // Tuning hold off timer.
-bool tuning_flag = false;               // Flag to indicate tuning
-uint8_t tuneHoldOff = 0;                // Timer to hold off display whilst tuning
 
 //
 // Current parameters
@@ -518,20 +515,6 @@ bool checkStopSeeking()
 // This function is called by the seek function process.
 void showFrequencySeek(uint16_t freq)
 {
-  // Check if tuning flag is set
-  if(tuneHoldOff)
-  {
-    if(tuning_flag)
-    {
-      if((millis() - tuning_timer) > tuneHoldOff)
-        tuning_flag = false;
-    }
-    else
-    {
-      tuning_timer = millis();
-      tuning_flag = true;
-    }
-  }
   currentFrequency = freq;
   drawScreen();
 }
@@ -547,13 +530,6 @@ bool doSeek(int16_t enc)
   {
     if(isSSB())
     {
-      if(tuneHoldOff)
-      {
-        // Tuning timer to hold off (FM/AM) display updates
-        tuning_flag = true;
-        tuning_timer = millis();
-      }
-
       updateBFO(currentBFO + enc * getCurrentStep(true)->step, true);
     }
     else
@@ -565,7 +541,6 @@ bool doSeek(int16_t enc)
       // Flag is set by rotary encoder and cleared on seek/scan entry
       seekStop = false;
       rx.seekStationProgress(showFrequencySeek, checkStopSeeking, enc>0? 1 : 0);
-      if(tuneHoldOff) tuning_flag = false;
       updateFrequency(rx.getFrequency(), true);
     }
   }
@@ -603,13 +578,6 @@ bool doTune(int16_t enc, bool fast = false)
   //
   if(isSSB())
   {
-    if(tuneHoldOff)
-    {
-      // Tuning timer to hold off (SSB) display updates
-      tuning_flag = true;
-      tuning_timer = millis();
-    }
-
     uint32_t step = getCurrentStep(fast)->step;
     uint32_t stepAdjust = (currentFrequency * 1000 + currentBFO) % step;
     step = !stepAdjust? step : enc>0? step - stepAdjust : stepAdjust;
@@ -622,13 +590,6 @@ bool doTune(int16_t enc, bool fast = false)
   //
   else
   {
-    if(tuneHoldOff)
-    {
-      // Tuning timer to hold off (FM/AM) display updates
-      tuning_flag = true;
-      tuning_timer = millis();
-    }
-
     uint16_t step = getCurrentStep(fast)->step;
     uint16_t stepAdjust = currentFrequency % step;
     stepAdjust = (currentMode==FM) && (step==20)? (stepAdjust+10) % step : stepAdjust;
@@ -656,13 +617,6 @@ bool doDigit(int16_t enc)
   // SSB tuning
   if(isSSB())
   {
-    if(tuneHoldOff)
-    {
-      // Tuning timer to hold off (SSB) display updates
-      tuning_flag = true;
-      tuning_timer = millis();
-    }
-
     updated = updateBFO(currentBFO + enc * getFreqInputStep(), false);
   }
 
@@ -671,13 +625,6 @@ bool doDigit(int16_t enc)
   //
   else
   {
-    if(tuneHoldOff)
-    {
-      // Tuning timer to hold off (FM/AM) display updates
-      tuning_flag = true;
-      tuning_timer = millis();
-    }
-
     // Tune to a new frequency
     updated = updateFrequency(currentFrequency + enc * getFreqInputStep(), false);
   }
@@ -1001,13 +948,6 @@ void loop()
   // Tick NETWORK time, connecting to WiFi if requested
   netTickTime();
 
-  // Check if tuning flag is set
-  if(tuneHoldOff && tuning_flag && ((currentTime - tuning_timer) > tuneHoldOff))
-  {
-    tuning_flag = false;
-    needRedraw = true;
-  }
-
   // Run clock
   needRedraw |= clockTickTime();
 

changelog/+holdoff.changed.md

@@ -0,0 +1 @@
+Remove the ENABLE_HOLDOFF compile-time option.

changelog/+holdoff.removed.md

@@ -47,7 +47,7 @@ HALF_STEP=1 PORT=/dev/tty.usbmodem14401 make upload
 
 ## Decoding stack traces
 
-To decode a stack trace (printed via serial port) use the following tool: https://esphome.github.io/esp-stacktrace-decoder/
+To decode a stack trace (printed via serial port) use the following tool: <https://esphome.github.io/esp-stacktrace-decoder/>
 
 ## Enabling the pre-commit hooks
 

docs/source/development.md

@@ -113,9 +113,7 @@ From now on you can switch the modes as you want and connect to your receiver ei
 When on the go, you can set up a mobile Wi-Fi hotspot on your smartphone and use it to connect the receiver to the internet.
 ```
 
-### Receiver settings available via Wi-Fi only
-
-* **Tuning Display Delay** - time in milliseconds to delay screen updates while tuning/seeking, 0 (disabled) ... 255. Makes the tuning process a bit faster because the screen is updated less often.
+<!-- ### Receiver settings available via Wi-Fi only -->
 
 ## Schedule