From 58d3f2fb816aafc753c0a0ee8e1f09a868c32711 Mon Sep 17 00:00:00 2001 From: Greg Shear Date: Mon, 9 Mar 2026 22:28:26 -0400 Subject: [PATCH] Add Azure identity fields to data plane details popup Closes #1917 --- src/api/dataPlanes.ts | 4 ++++ .../Entity/DetailsForm/useDataPlaneOptions.ts | 2 ++ .../tables/DataPlanes/DataPlaneDialog.tsx | 24 +++++++++++++++++++ .../dataPlanes/useEvaluateDataPlaneOptions.ts | 4 ++++ src/lang/en-US/Data.ts | 3 +++ 5 files changed, 37 insertions(+) diff --git a/src/api/dataPlanes.ts b/src/api/dataPlanes.ts index 2e71de0706..fc01814d52 100644 --- a/src/api/dataPlanes.ts +++ b/src/api/dataPlanes.ts @@ -26,6 +26,8 @@ export interface BaseDataPlaneQuery { cidr_blocks: string[] | null; gcp_service_account_email: string | null; aws_iam_user_arn: string | null; + azure_application_name: string | null; + azure_application_client_id: string | null; data_plane_fqdn: string | null; // aws_link_endpoints: AwsLinkEndpoint | null; } @@ -38,6 +40,8 @@ const COLUMNS = [ 'cidr_blocks', 'gcp_service_account_email', 'aws_iam_user_arn', + // 'azure_application_name', TODO uncomment after RLS policy is updated + 'azure_application_client_id', // 'aws_link_endpoints', TODO uncomment after https://github.com/estuary/flow/pull/1816 is done ]; diff --git a/src/components/shared/Entity/DetailsForm/useDataPlaneOptions.ts b/src/components/shared/Entity/DetailsForm/useDataPlaneOptions.ts index 35fd48531c..784a553fb7 100644 --- a/src/components/shared/Entity/DetailsForm/useDataPlaneOptions.ts +++ b/src/components/shared/Entity/DetailsForm/useDataPlaneOptions.ts @@ -42,6 +42,8 @@ export const useDataPlaneOptions = () => { gcp_service_account_email: null, aws_iam_user_arn: null, data_plane_fqdn: null, + azure_application_name: null, + azure_application_client_id: null, }, dataPlaneNames.at(0) ) diff --git a/src/components/tables/DataPlanes/DataPlaneDialog.tsx b/src/components/tables/DataPlanes/DataPlaneDialog.tsx index 930ac6fb6e..7ad3dc023f 100644 --- a/src/components/tables/DataPlanes/DataPlaneDialog.tsx +++ b/src/components/tables/DataPlanes/DataPlaneDialog.tsx @@ -130,6 +130,30 @@ function DataPlaneDialog({ onClose, dataPlane }: DataPlaneDialogProps) { }, ]} /> + + + { gcp_service_account_email: null, aws_iam_user_arn: null, data_plane_fqdn: null, + azure_application_name: null, + azure_application_client_id: null, }, defaultDataPlaneName ); @@ -134,6 +136,8 @@ export const useEvaluateDataPlaneOptions = () => { gcp_service_account_email: null, aws_iam_user_arn: null, data_plane_fqdn: null, + azure_application_name: null, + azure_application_client_id: null, }, existingDataPlane.name ?? '' ) diff --git a/src/lang/en-US/Data.ts b/src/lang/en-US/Data.ts index b96c5e6cb9..ae48934b63 100644 --- a/src/lang/en-US/Data.ts +++ b/src/lang/en-US/Data.ts @@ -33,6 +33,9 @@ export const Data: Record = { 'data.scope': `Scope`, 'data.gcpServiceAccount': `GCP Service Account Email`, 'data.awsIamUserArn': `AWS IAM User ARN`, + 'data.azureApplicationName': `Azure Application Name`, + 'data.azureApplicationClientId': `Azure Application Client ID`, + 'data.azureConsentLink': `Azure Consent Link`, 'data.idProvider': `IAM OIDC`, 'data.errors': `Errors`, 'data.completed': `Completed`,