Display --log-vmtrace option only for aleth.

Other modules that use logginOptions - aleth-vm has its own means of tracing and aleth-key don't need it.
Correctly enable vmtrace in log setup in testeth.

Author: gumb0

CHANGELOG.md

@@ -14,7 +14,7 @@
 - Changed: [#5532](https://github.com/ethereum/aleth/pull/5532) The leveldb is upgraded to 1.22. This is breaking change on Windows and the old databases are not compatible.
 - Changed: [#5559](https://github.com/ethereum/aleth/pull/5559) Update peer validation error messages.
 - Changed: [#5568](https://github.com/ethereum/aleth/pull/5568) Improve rlpx handshake log messages and create new rlpx log channel.
-- Changed: [#5570](https://github.com/ethereum/aleth/pull/5570) Now it's not necessary to recompile with VMTRACE flag to get VM trace log. Just use `testeth -- --vmtrace` or `aleth -v 4 --log-channels vmtrace`.
+- Changed: [#5570](https://github.com/ethereum/aleth/pull/5570) Now it's not necessary to recompile with VMTRACE flag to get VM trace log. Just use `testeth -- --vmtrace` or `aleth -v 4 --log-vmtrace`.
 - Changed: [#5576](https://github.com/ethereum/aleth/pull/5576) Moved sstore_combinations and static_Call50000_sha256 tests to stTimeConsuming test suite. (testeth runs them only with `--all` flag)
 - Changed: [#5589](https://github.com/ethereum/aleth/pull/5589) Make aleth output always line-buffered even when redirected to file or pipe.
 - Changed: [#5602](https://github.com/ethereum/aleth/pull/5602) Better predicting external IP address and UDP port.

aleth/main.cpp

@@ -327,6 +327,11 @@ int main(int argc, char** argv)
     LoggingOptions loggingOptions;
     po::options_description loggingProgramOptions(
         createLoggingProgramOptions(c_lineWidth, loggingOptions, logChannels));
+    // log-vmtrace is needed only in aleth
+    auto addLoggingOption = loggingProgramOptions.add_options();
+    addLoggingOption("log-vmtrace", po::bool_switch(&loggingOptions.vmTrace),
+        "Enable VM trace log (requires log-verbosity 4).\n");
+
 
     po::options_description generalOptions("GENERAL OPTIONS", c_lineWidth);
     auto addGeneralOption = generalOptions.add_options();

libdevcore/LoggingProgramOptions.cpp

@@ -42,8 +42,6 @@ po::options_description createLoggingProgramOptions(
             ->value_name("<channel_list>")
             ->multitoken(),
         "Space-separated list of the log channels to hide.\n");
-    addLoggingOption("log-vmtrace", po::bool_switch(&_options.vmTrace),
-        "Enable VM trace log (requires log-verbosity 4).\n");
 
     return optionsDescr;
 }

test/tools/libtesteth/Options.cpp

@@ -83,7 +83,7 @@ void printVersion()
 }
 }
 
-void Options::setVerbosity(int _level)
+void Options::setVerbosity(int _level, bool _vmTrace)
 {
     static boost::iostreams::stream<boost::iostreams::null_sink> nullOstream(
         (boost::iostreams::null_sink()));
@@ -98,6 +98,7 @@ void Options::setVerbosity(int _level)
     }
     else if (_level == 1 || _level == 2)
         logOptions.verbosity = VerbositySilent;
+    logOptions.vmTrace = _vmTrace;
     dev::setupLogging(logOptions);
 }
 
@@ -360,7 +361,7 @@ Options::Options(int argc, const char** argv)
     }
 
     // If no verbosity is set. use default
-    setVerbosity(verbosity == -1 ? 1 : verbosity);
+    setVerbosity(verbosity == -1 ? 1 : verbosity, vmtrace);
 }
 
 Options const& Options::get(int argc, const char** argv)

test/tools/libtesteth/Options.h

@@ -71,7 +71,7 @@ class Options
 private:
     Options(int argc = 0, const char** argv = 0);
     Options(Options const&) = delete;
-    void setVerbosity(int _level);
+    void setVerbosity(int _level, bool _vmTrace);
 };
 
 } //namespace test