Check balance in SELFDESTRUCT only when really necessary

chfast · chfast · commit 29ed24eddb9e · 2019-08-19T10:42:06.000+02:00
diff --git a/libaleth-interpreter/VM.cpp b/libaleth-interpreter/VM.cpp
@@ -384,9 +384,8 @@ void VM::interpretCases()
             if (m_rev >= EVMC_TANGERINE_WHISTLE)
             {
                 // After EIP158 zero-value suicides do not have to pay account creation gas.
-                u256 const balance =
-                    fromEvmC(m_context->host->get_balance(m_context, &m_message->destination));
-                if (balance > 0 || m_rev == EVMC_TANGERINE_WHISTLE)
+                if (m_rev == EVMC_TANGERINE_WHISTLE ||
+                    fromEvmC(m_context->host->get_balance(m_context, &m_message->destination)) > 0)
                 {
                     // After EIP150 hard fork charge additional cost of sending
                     // ethers to non-existing account.

Original file line number	Diff line number	Diff line change
`@@ -384,9 +384,8 @@ void VM::interpretCases()`
`384`	`384`	`if (m_rev >= EVMC_TANGERINE_WHISTLE)`
`385`	`385`	`{`
`386`	`386`	`// After EIP158 zero-value suicides do not have to pay account creation gas.`
`387`		`- u256 const balance =`
`388`		`- fromEvmC(m_context->host->get_balance(m_context, &m_message->destination));`
`389`		`- if (balance > 0 \|\| m_rev == EVMC_TANGERINE_WHISTLE)`
	`387`	`+ if (m_rev == EVMC_TANGERINE_WHISTLE \|\|`
	`388`	`+ fromEvmC(m_context->host->get_balance(m_context, &m_message->destination)) > 0)`
`390`	`389`	`{`
`391`	`390`	`// After EIP150 hard fork charge additional cost of sending`
`392`	`391`	`// ethers to non-existing account.`