Address PR feedback

Change position of const keyword, make some variables const, remove unnecessary "p2p.connect", change log level to trace

Author: halfalicious

libp2p/Common.cpp

@@ -15,7 +15,7 @@ using namespace std;
 const NodeIPEndpoint UnspecifiedNodeIPEndpoint = NodeIPEndpoint{{}, 0, 0};
 const Node UnspecifiedNode = Node{{}, UnspecifiedNodeIPEndpoint};
 
-const char* packetTypeToString(PacketType _packetType)
+char const* packetTypeToString(PacketType _packetType)
 {
     switch (_packetType)
     {

libp2p/Common.h

@@ -89,7 +89,7 @@ enum PacketType
     UserPacket = 0x10
 };
 
-const char* packetTypeToString(PacketType _packetType);
+char const* packetTypeToString(PacketType _packetType);
 
 enum DisconnectReason
 {

libp2p/RLPxHandshake.cpp

@@ -367,9 +367,9 @@ void RLPXHandshake::transition(boost::system::error_code _ech)
                                   << m_socket->remoteEndpoint() << ". Validating contents...";
 
                     /// check frame size
-                    bytes& header = m_handshakeInBuffer;
-                    uint32_t frameSize = (uint32_t)(header[2]) | (uint32_t)(header[1]) << 8 |
-                                         (uint32_t)(header[0]) << 16;
+                    bytes const& header = m_handshakeInBuffer;
+                    uint32_t const frameSize = (uint32_t)(header[2]) | (uint32_t)(header[1]) << 8 |
+                                               (uint32_t)(header[0]) << 16;
                     constexpr size_t expectedFrameSizeBytes = 1024;
                     if (frameSize > expectedFrameSizeBytes)
                     {
@@ -472,14 +472,6 @@ void RLPXHandshake::transition(boost::system::error_code _ech)
     }
 }
 
-const char* RLPXHandshake::connectionDirectionString() const
-{
-    if (m_originated)
-        return "p2p.connect.egress: ";
-    else
-        return "p2p.connect.ingress: ";
-}
-
 bool RLPXHandshake::remoteSocketConnected() const
 {
     return m_socket && m_socket->isConnected() &&

libp2p/RLPxHandshake.h

@@ -94,7 +94,10 @@ class RLPXHandshake: public std::enable_shared_from_this<RLPXHandshake>
     virtual void transition(boost::system::error_code _ech = boost::system::error_code());
 
     /// Get a string indicating if the connection is incoming or outgoing
-    const char* connectionDirectionString() const;
+    inline char const* connectionDirectionString() const
+    {
+        return m_originated ? "egress" : "ingress";
+    }
 
     /// Determine if the remote socket is still connected
     bool remoteSocketConnected() const;
@@ -132,7 +135,7 @@ class RLPXHandshake: public std::enable_shared_from_this<RLPXHandshake>
     /// Timer which enforces c_timeout. Reset for each stage of the handshake.
     ba::steady_timer m_idleTimer;
 
-    Logger m_logger{createLogger(VerbosityDebug, "rlpx")};
+    Logger m_logger{createLogger(VerbosityTrace, "rlpx")};
     Logger m_errorLogger{createLogger(VerbosityError, "rlpx")};
 };