Fix db::Slice pointing to non-existent data

gumb0 · gumb0 · commit e95ef799da7f · 2018-02-12T12:28:05.000+01:00
diff --git a/libethereum/BlockChain.cpp b/libethereum/BlockChain.cpp
@@ -51,7 +51,8 @@ namespace fs = boost::filesystem;
 
 namespace
 {
-db::Slice const c_sliceChainStart{"chainStart"};
+std::string const c_chainStart{"chainStart"};
+db::Slice const c_sliceChainStart{c_chainStart};
 }
 
 #if defined(_WIN32)
@@ -1590,7 +1591,7 @@ VerifiedBlockRef BlockChain::verifyBlock(bytesConstRef _block, std::function<voi
 
 void BlockChain::setChainStartBlockNumber(unsigned _number)
 {
-    h256 const& hash = numberHash(_number);
+    h256 const hash = numberHash(_number);
     if (!hash)
         BOOST_THROW_EXCEPTION(UnknownBlockNumber());
 

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,8 @@ namespace fs = boost::filesystem;`
`51`	`51`
`52`	`52`	`namespace`
`53`	`53`	`{`
`54`		`-db::Slice const c_sliceChainStart{"chainStart"};`
	`54`	`+std::string const c_chainStart{"chainStart"};`
	`55`	`+db::Slice const c_sliceChainStart{c_chainStart};`
`55`	`56`	`}`
`56`	`57`
`57`	`58`	`#if defined(_WIN32)`
`@@ -1590,7 +1591,7 @@ VerifiedBlockRef BlockChain::verifyBlock(bytesConstRef _block, std::function<voi`
`1590`	`1591`
`1591`	`1592`	`void BlockChain::setChainStartBlockNumber(unsigned _number)`
`1592`	`1593`	`{`
`1593`		`- h256 const& hash = numberHash(_number);`
	`1594`	`+ h256 const hash = numberHash(_number);`
`1594`	`1595`	`if (!hash)`
`1595`	`1596`	`BOOST_THROW_EXCEPTION(UnknownBlockNumber());`
`1596`	`1597`