Skip to content

Commit 75ba27d

Browse files
committed
Change signature check to covpass
remove invalid samples rename image files to fit schema
1 parent 25eb744 commit 75ba27d

File tree

10 files changed

+29
-12
lines changed

10 files changed

+29
-12
lines changed

.github/workflows/dgc-testdata-verification.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,20 +43,22 @@ jobs:
4343
- name: Validate DCC QA Pull Request
4444
if: ${{ github.event_name != 'workflow_dispatch' }}
4545
env:
46-
DCC_KID_LIST: ${{ secrets.DCC_KID_LIST }}
47-
DCC_CERT_LIST: ${{ secrets.DCC_CERT_LIST }}
46+
#DCC_KID_LIST: ${{ secrets.DCC_KID_LIST }}
47+
#DCC_CERT_LIST: ${{ secrets.DCC_CERT_LIST }}
4848
DCC_VALUESET_LIST_ALT: ${{ secrets.DCC_VALUESET_LIST_ALT }}
49+
DSC_LIST: https://de.test.dscg.ubirch.com/trustList/DSC/
4950
# Not official reference, just used for quick check of pull requests
5051
DCC_VALUESET_LIST: https://distribution-cff4f7147260.dcc-rules.de/valuesets
5152
DCC_SCHEMA_BASE_URI: https://raw.githubusercontent.com/ehn-dcc-development/ehn-dcc-schema/release/
5253
run: |
53-
pytest --tb=short --no-signature-check -rfEx --md-report --md-report-verbose=1 --md-report-zeros=number --html=dgc_testdata_report.html --self-contained-html --junit-xml=pytest.xml
54+
pytest --tb=short -rfEx --md-report --md-report-verbose=1 --md-report-zeros=number --html=dgc_testdata_report.html --self-contained-html --junit-xml=pytest.xml
5455
- name: Validate DCC QA Workflow Dispatch
5556
if: ${{ github.event_name == 'workflow_dispatch' }}
5657
env:
57-
DCC_KID_LIST: ${{ secrets.DCC_KID_LIST }}
58-
DCC_CERT_LIST: ${{ secrets.DCC_CERT_LIST }}
58+
#DCC_KID_LIST: ${{ secrets.DCC_KID_LIST }}
59+
#DCC_CERT_LIST: ${{ secrets.DCC_CERT_LIST }}
5960
DCC_VALUESET_LIST: ${{ secrets.DCC_VALUESET_LIST }}
61+
DSC_LIST: https://de.test.dscg.ubirch.com/trustList/DSC/
6062
DCC_VALUESET_LIST_ALT: ${{ secrets.DCC_VALUESET_LIST_ALT }}
6163
DCC_SCHEMA_BASE_URI: ${{ secrets.DCC_SCHEMA_BASE_URI }}
6264
run: |

KR/1.3.0/REC_KR.png

-89.7 KB
Binary file not shown.

KR/1.3.0/TEST_KR.png

-92.3 KB
Binary file not shown.

KR/1.3.0/VAC_KR.png

-88.9 KB
Binary file not shown.

KR/1.3.0/readme.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
# KR: Republic of Korea(South Korea)
22

3+
Signer key has been removed from testing environment.
4+
QR codes have become invalid.
5+
36
## Vaccination
47

5-
![VAC_KR.png](VAC_KR.png)
68

79
## Test
810

9-
![TEST_KR.png](TEST_KR.png)
1011

1112
## Recovery
1213

13-
![REC_KR.png](REC_KR.png)

tests/constants.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@
1111
# URLs
1212

1313
# Former hard coded URLs are now deprecated and may be taken out of order in the future
14-
ACC_KID_LIST = os.environ['DCC_KID_LIST']
15-
ACC_CERT_LIST = os.environ['DCC_CERT_LIST']
14+
#ACC_KID_LIST = os.environ['DCC_KID_LIST']
15+
#ACC_CERT_LIST = os.environ['DCC_CERT_LIST']
16+
DSC_LIST = os.environ['DSC_LIST']
1617
VALUESET_LIST = os.environ['DCC_VALUESET_LIST']
1718
VALUESET_LIST_ALTERNATIVE = os.environ['DCC_VALUESET_LIST_ALT']
1819
SCHEMA_BASE_URI = os.environ['DCC_SCHEMA_BASE_URI']

tests/test_qrqualitycheck.py

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,22 @@ def valuesets_from_environment():
6767
return valuesets
6868

6969
@filecache(HOUR)
70-
def certificates_from_environment():
71-
"Downloads and caches the certificates from the acceptance environment"
70+
def certificates_from_environment():
71+
"""Downloads and caches the certificates from the acceptance environment
72+
using API for CovPass Check app"""
73+
response = requests.get(constants.DSC_LIST)
74+
if not response.ok:
75+
pytest.fail("DSC list not reachable")
76+
77+
dsc_list = json.loads(response.text[response.text.find('\n'):])
78+
kid_dict = { dsc['kid'] : dsc['rawData'] for dsc in dsc_list['certificates'] }
79+
return kid_dict
80+
81+
82+
@filecache(HOUR)
83+
def _certificates_from_environment(): # Uses API of demo implementation for verifier app
84+
"""Downloads and caches the certificates from the acceptance environment
85+
using API for template verifier app"""
7286
def get_key_id_dict():
7387
response = requests.get(constants.ACC_KID_LIST)
7488
if not response.ok:

0 commit comments

Comments
 (0)