UI: updates to how we handle unknown mount type (hashicorp#9349) (hashicorp#9378)

* updates to how we handle unknown mount type

* update test

Co-authored-by: Dan Rivera <dan.rivera@hashicorp.com>

Author: hc-github-team-secure-vault-core

ui/app/components/secret-engine/list.hbs

@@ -83,15 +83,13 @@
           @hasChevron={{false}}
           data-test-popup-menu-trigger
         />
-        {{#if (not-eq (get (engines-display-data backend.type) "type") "generic")}}
-          <dd.Interactive
-            @route={{backend.backendConfigurationLink}}
-            @model={{backend.id}}
-            data-test-popup-menu="view-configuration"
-          >
-            View configuration
-          </dd.Interactive>
-        {{/if}}
+        <dd.Interactive
+          @route={{backend.backendConfigurationLink}}
+          @model={{backend.id}}
+          data-test-popup-menu="view-configuration"
+        >
+          View configuration
+        </dd.Interactive>
         {{#if (not-eq backend.type "cubbyhole")}}
           <dd.Interactive
             @color="critical"

ui/app/components/secret-engine/list.ts

@@ -80,10 +80,10 @@ export default class SecretEngineList extends Component<Args> {
       } else {
         return `${displayData.displayName}`;
       }
-    } else if (displayData.type === 'generic') {
-      // If a mounted engine type doesn't match any known type, the type is returned as 'generic' and set this tooltip.
+    } else if (displayData.type === 'unknown') {
+      // If a mounted engine type doesn't match any known type, the type is returned as 'unknown' and set this tooltip.
       // Handles issue when a user externally mounts an engine that doesn't follow the expected naming conventions for what's in the binary, despite being a valid engine.
-      return 'This plugin is not supported by the UI. Please use the CLI to manage this engine.';
+      return `This engine's type is not recognized by the UI. Please use the CLI to manage this engine.`;
     } else {
       // If the engine type is recognized but not supported, we only show configuration view and set this tooltip.
       return 'The UI only supports configuration views for these secret engines. The CLI must be used to manage other engine resources.';

ui/app/helpers/engines-display-data.ts

@@ -24,10 +24,11 @@ import { ALL_ENGINES } from 'vault/utils/all-engines-metadata';
 export default function engineDisplayData(methodType: string) {
   const engine = ALL_ENGINES?.find((t) => t.type === methodType);
   if (!engine && methodType) {
-    // Fallback to a generic engine if no match found but type is provided
+    // Fallback to a unknown engine if no match found but type is provided
     return {
-      displayName: 'Generic plugin',
-      type: 'generic',
+      displayName: 'Unknown plugin',
+      type: 'unknown',
+      isOldEngine: true,
       glyph: 'lock',
       mountCategory: ['secret', 'auth'],
     };

ui/tests/integration/components/list-test.js

@@ -73,8 +73,8 @@ module('Integration | Component | secret-engine/list', function (hooks) {
     assert
       .dom('.hds-tooltip-container')
       .hasText(
-        'This plugin is not supported by the UI. Please use the CLI to manage this engine.',
-        'shows tooltip text for unsupported engine'
+        `This engine's type is not recognized by the UI. Please use the CLI to manage this engine.`,
+        'shows tooltip text for unknown engine'
       );
   });