From 856d4c180c0e7619a6b0c33532648afe10fa2a1c Mon Sep 17 00:00:00 2001 From: Bipinkumar27 Date: Wed, 26 Apr 2023 19:06:05 +0530 Subject: [PATCH 1/3] JAVA-15032: Changes made for adding the test cases custom userAgent in request header --- .../httpclient/HttpClientHeadersLiveTest.java | 20 ++++++++----------- 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/httpclient-simple/src/test/java/com/baeldung/httpclient/HttpClientHeadersLiveTest.java b/httpclient-simple/src/test/java/com/baeldung/httpclient/HttpClientHeadersLiveTest.java index 616b6470af1e..3992fd821e8a 100644 --- a/httpclient-simple/src/test/java/com/baeldung/httpclient/HttpClientHeadersLiveTest.java +++ b/httpclient-simple/src/test/java/com/baeldung/httpclient/HttpClientHeadersLiveTest.java @@ -25,26 +25,22 @@ class HttpClientHeadersLiveTest { @Test void whenClientUsesCustomUserAgent_thenCorrect() throws IOException { - final HttpGet request = new HttpGet(SAMPLE_URL); - - try (CloseableHttpClient client = HttpClients.custom() + final CloseableHttpClient client = HttpClients.custom() .setUserAgent("Mozilla/5.0 Firefox/26.0") - .build()) { + .build(); + final HttpGet request = new HttpGet(SAMPLE_URL); - String response = client.execute(request, new BasicHttpClientResponseHandler()); - logger.info("Response -> {}", response); - } + String response = client.execute(request, new BasicHttpClientResponseHandler()); + logger.info("Response -> {}", response); } @Test void whenRequestHasCustomUserAgent_thenCorrect() throws IOException { + CloseableHttpClient client = HttpClients.createDefault(); final HttpGet request = new HttpGet(SAMPLE_URL); request.setHeader(HttpHeaders.USER_AGENT, "Mozilla/5.0 Firefox/26.0"); - - try (CloseableHttpClient client = HttpClients.createDefault()) { - String response = client.execute(request, new BasicHttpClientResponseHandler()); - logger.info("Response -> {}", response); - } + String response = client.execute(request, new BasicHttpClientResponseHandler()); + logger.info("Response -> {}", response); } @Test From 4128c1a3b01d7a2b6f6e461e0527c3f550fdf0b0 Mon Sep 17 00:00:00 2001 From: Bipinkumar27 Date: Wed, 26 Apr 2023 19:10:53 +0530 Subject: [PATCH 2/3] JAVA-15032: Changes made for adding the test cases custom userAgent in request header --- .../HttpClientHeaderV4LiveTest.java | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/apache-httpclient4/src/test/java/com/baeldung/httpclient/HttpClientHeaderV4LiveTest.java b/apache-httpclient4/src/test/java/com/baeldung/httpclient/HttpClientHeaderV4LiveTest.java index eef813b3ff85..f55a4a570398 100644 --- a/apache-httpclient4/src/test/java/com/baeldung/httpclient/HttpClientHeaderV4LiveTest.java +++ b/apache-httpclient4/src/test/java/com/baeldung/httpclient/HttpClientHeaderV4LiveTest.java @@ -1,15 +1,23 @@ package com.baeldung.httpclient; +import static org.apache.http.HttpHeaders.USER_AGENT; + import java.io.IOException; import org.apache.http.HttpHeaders; import org.apache.http.client.HttpClient; +import org.apache.http.client.methods.HttpGet; import org.apache.http.client.methods.HttpUriRequest; import org.apache.http.client.methods.RequestBuilder; +import org.apache.http.impl.client.BasicResponseHandler; +import org.apache.http.impl.client.CloseableHttpClient; import org.apache.http.impl.client.HttpClients; import org.junit.jupiter.api.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; class HttpClientHeaderV4LiveTest { + private final Logger logger = LoggerFactory.getLogger(this.getClass()); private static final String SAMPLE_URL = "http://www.github.com"; @Test @@ -21,4 +29,23 @@ void givenRequestBuildWithBuilder_whenRequestHasCustomContentType_thenCorrect() .build(); client.execute(request); } + + @Test + void whenClientUsesCustomUserAgent_thenCorrect() throws IOException { + CloseableHttpClient client = HttpClients.custom() + .setUserAgent("Mozilla/5.0 Firefox/26.0") + .build(); + final HttpGet request = new HttpGet(SAMPLE_URL); + String response = client.execute(request, new BasicResponseHandler()); + logger.info("Response -> {}", response); + } + + @Test + void whenRequestHasCustomUserAgent_thenCorrect() throws IOException { + CloseableHttpClient client = HttpClients.createDefault(); + final HttpGet request = new HttpGet(SAMPLE_URL); + request.setHeader(USER_AGENT,"Mozilla/5.0 Firefox/26.0"); + String response = client.execute(request, new BasicResponseHandler()); + logger.info("Response -> {}", response); + } } \ No newline at end of file From c35316994e4bdd191affca44780dfe62ee2881de Mon Sep 17 00:00:00 2001 From: Bipinkumar27 Date: Mon, 1 May 2023 21:52:20 +0530 Subject: [PATCH 3/3] JAVA-15032: Changes made for incorporarting review comments --- .../HttpClientHeaderV4LiveTest.java | 27 ------------------- 1 file changed, 27 deletions(-) diff --git a/apache-httpclient4/src/test/java/com/baeldung/httpclient/HttpClientHeaderV4LiveTest.java b/apache-httpclient4/src/test/java/com/baeldung/httpclient/HttpClientHeaderV4LiveTest.java index f55a4a570398..eef813b3ff85 100644 --- a/apache-httpclient4/src/test/java/com/baeldung/httpclient/HttpClientHeaderV4LiveTest.java +++ b/apache-httpclient4/src/test/java/com/baeldung/httpclient/HttpClientHeaderV4LiveTest.java @@ -1,23 +1,15 @@ package com.baeldung.httpclient; -import static org.apache.http.HttpHeaders.USER_AGENT; - import java.io.IOException; import org.apache.http.HttpHeaders; import org.apache.http.client.HttpClient; -import org.apache.http.client.methods.HttpGet; import org.apache.http.client.methods.HttpUriRequest; import org.apache.http.client.methods.RequestBuilder; -import org.apache.http.impl.client.BasicResponseHandler; -import org.apache.http.impl.client.CloseableHttpClient; import org.apache.http.impl.client.HttpClients; import org.junit.jupiter.api.Test; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; class HttpClientHeaderV4LiveTest { - private final Logger logger = LoggerFactory.getLogger(this.getClass()); private static final String SAMPLE_URL = "http://www.github.com"; @Test @@ -29,23 +21,4 @@ void givenRequestBuildWithBuilder_whenRequestHasCustomContentType_thenCorrect() .build(); client.execute(request); } - - @Test - void whenClientUsesCustomUserAgent_thenCorrect() throws IOException { - CloseableHttpClient client = HttpClients.custom() - .setUserAgent("Mozilla/5.0 Firefox/26.0") - .build(); - final HttpGet request = new HttpGet(SAMPLE_URL); - String response = client.execute(request, new BasicResponseHandler()); - logger.info("Response -> {}", response); - } - - @Test - void whenRequestHasCustomUserAgent_thenCorrect() throws IOException { - CloseableHttpClient client = HttpClients.createDefault(); - final HttpGet request = new HttpGet(SAMPLE_URL); - request.setHeader(USER_AGENT,"Mozilla/5.0 Firefox/26.0"); - String response = client.execute(request, new BasicResponseHandler()); - logger.info("Response -> {}", response); - } } \ No newline at end of file