From 38337876464a488c49f1dfb83f7ed28448012990 Mon Sep 17 00:00:00 2001 From: aagarwal Date: Tue, 20 Feb 2018 14:26:23 +0530 Subject: [PATCH 1/4] Added for BAEL-1584 --- .../findanelement/FindElementInAList.java | 65 ++++++++++ .../findanelement/FindAnElementTest.java | 117 ++++++++++++++++++ 2 files changed, 182 insertions(+) create mode 100644 core-java-8/src/main/java/com/baeldung/findanelement/FindElementInAList.java create mode 100644 core-java-8/src/test/java/com/baeldung/findanelement/FindAnElementTest.java diff --git a/core-java-8/src/main/java/com/baeldung/findanelement/FindElementInAList.java b/core-java-8/src/main/java/com/baeldung/findanelement/FindElementInAList.java new file mode 100644 index 000000000000..92f3f1abc2d3 --- /dev/null +++ b/core-java-8/src/main/java/com/baeldung/findanelement/FindElementInAList.java @@ -0,0 +1,65 @@ +package com.baeldung.findanelement; + +import java.util.List; +import java.util.Optional; +import org.apache.commons.collections4.IterableUtils; +import com.google.common.collect.Iterables; + +public class FindElementInAList { + + public T findUsingIndexOf(T element, List listOfIntegers) { + int index = listOfIntegers.indexOf(element); + if (index >= 0) { + return element; + } + return null; + } + + public T findUsingNormalForLoop(T element, List listOfIntegers) { + for (int i = 0; i < listOfIntegers.size(); i++) { + if (listOfIntegers.get(i).equals(element)) { + return listOfIntegers.get(i); + } + } + return null; + } + + public T findUsingEnhancedForLoop(T element, List listOfIntegers) { + for (T elementFromList : listOfIntegers) { + if (element.equals(elementFromList)) { + return elementFromList; + } + } + return null; + } + + public T findUsingStream(T element, List listOfIntegers) { + Optional foundElement = listOfIntegers + .stream() + .filter(integer -> integer.equals(element)) + .findFirst(); + return foundElement.isPresent() ? foundElement.get() : null; + } + + public T findUsingParallelStream(T element, List listOfIntegers) { + Optional foundElement = listOfIntegers + .parallelStream() + .filter(integer -> integer.equals(element)) + .findAny(); + return foundElement.isPresent() ? foundElement.get() : null; + } + + public T findUsingGuava(T element, List listOfIntegers) { + T foundElement = Iterables + .tryFind(listOfIntegers, currentelement -> currentelement.equals(element)) + .orNull(); + return foundElement; + } + + public T findUsingApacheCommon(T element, List listOfIntegers) { + T foundElement = IterableUtils + .find(listOfIntegers, currentelement -> currentelement.equals(element)); + return foundElement; + } + +} \ No newline at end of file diff --git a/core-java-8/src/test/java/com/baeldung/findanelement/FindAnElementTest.java b/core-java-8/src/test/java/com/baeldung/findanelement/FindAnElementTest.java new file mode 100644 index 000000000000..e8453129f5d5 --- /dev/null +++ b/core-java-8/src/test/java/com/baeldung/findanelement/FindAnElementTest.java @@ -0,0 +1,117 @@ +package com.baeldung.findanelement; + +import static org.junit.Assert.assertNull; +import static org.junit.Assert.assertTrue; +import java.util.ArrayList; +import java.util.List; +import org.junit.Test; + +public class FindAnElementTest { + + private static List listOfIntegers = new ArrayList<>(); + static { + listOfIntegers.add(new Integer(0)); + listOfIntegers.add(new Integer(1)); + listOfIntegers.add(new Integer(2)); + } + + private static FindElementInAList findElementInAList = new FindElementInAList<>(); + + @Test + public void givenElement_whenFoundUsingIndexOf_thenReturnElement() { + Integer element = new Integer(1); + Integer foundElement = findElementInAList.findUsingIndexOf(element, listOfIntegers); + assertTrue(foundElement.equals(element)); + } + + @Test + public void givenElement_whenNotFoundUsingIndexOf_thenReturnNull() { + Integer foundElement = findElementInAList.findUsingIndexOf(new Integer(5), listOfIntegers); + assertNull(foundElement); + } + + @Test + public void givenElement_whenFoundUsingNormalForLoop_thenReturnElement() { + Integer element = new Integer(1); + Integer foundElement = findElementInAList.findUsingNormalForLoop(element, listOfIntegers); + assertTrue(foundElement.equals(element)); + } + + @Test + public void givenElement_whenNotFoundUsingNormalForLoop_thenReturnNull() { + Integer element = new Integer(5); + Integer foundElement = findElementInAList.findUsingNormalForLoop(element, listOfIntegers); + assertNull(foundElement); + } + + @Test + public void givenElement_whenFoundUsingEnhancedForLoop_thenReturnElement() { + Integer element = new Integer(1); + Integer foundElement = findElementInAList.findUsingEnhancedForLoop(element, listOfIntegers); + assertTrue(foundElement.equals(element)); + } + + @Test + public void givenElement_whenNotFoundUsingEnhancedForLoop_thenReturnNull() { + Integer element = new Integer(5); + Integer foundElement = findElementInAList.findUsingEnhancedForLoop(element, listOfIntegers); + assertNull(foundElement); + } + + @Test + public void givenElement_whenFoundUsingStream_thenReturnElement() { + Integer element = new Integer(1); + Integer foundElement = findElementInAList.findUsingStream(element, listOfIntegers); + assertTrue(foundElement.equals(element)); + } + + @Test + public void givenElement_whenNotFoundUsingStream_thenReturnNull() { + Integer element = new Integer(5); + Integer foundElement = findElementInAList.findUsingStream(element, listOfIntegers); + assertNull(foundElement); + } + + @Test + public void givenElement_whenFoundUsingParallelStream_thenReturnElement() { + Integer element = new Integer(1); + Integer foundElement = findElementInAList.findUsingParallelStream(element, listOfIntegers); + assertTrue(foundElement.equals(element)); + } + + @Test + public void givenElement_whenNotFoundUsingParallelStream_thenReturnNull() { + Integer element = new Integer(5); + Integer foundElement = findElementInAList.findUsingParallelStream(element, listOfIntegers); + assertNull(foundElement); + } + + @Test + public void givenElement_whenFoundUsingGuava_thenReturnElement() { + Integer element = new Integer(1); + Integer foundElement = findElementInAList.findUsingGuava(element, listOfIntegers); + assertTrue(foundElement.equals(element)); + } + + @Test + public void givenElement_whenNotFoundUsingGuava_thenReturnNull() { + Integer element = new Integer(5); + Integer foundElement = findElementInAList.findUsingGuava(element, listOfIntegers); + assertNull(foundElement); + } + + @Test + public void givenElement_whenFoundUsingApacheCommons_thenReturnElement() { + Integer element = new Integer(1); + Integer foundElement = findElementInAList.findUsingApacheCommon(element, listOfIntegers); + assertTrue(foundElement.equals(element)); + } + + @Test + public void givenElement_whenNotFoundUsingApacheCommons_thenReturnNull() { + Integer element = new Integer(5); + Integer foundElement = findElementInAList.findUsingApacheCommon(element, listOfIntegers); + assertNull(foundElement); + } + +} \ No newline at end of file From 65d7284aa7515e4596239b63b77ec310919b686e Mon Sep 17 00:00:00 2001 From: aagarwal Date: Tue, 27 Feb 2018 11:54:21 +0530 Subject: [PATCH 2/4] updated for BAEL-1584 --- .../findanelement/FindElementInAList.java | 103 +++++---- .../findanelement/FindAnElementTest.java | 209 +++++++++--------- 2 files changed, 159 insertions(+), 153 deletions(-) diff --git a/core-java-8/src/main/java/com/baeldung/findanelement/FindElementInAList.java b/core-java-8/src/main/java/com/baeldung/findanelement/FindElementInAList.java index 92f3f1abc2d3..a8368188a16f 100644 --- a/core-java-8/src/main/java/com/baeldung/findanelement/FindElementInAList.java +++ b/core-java-8/src/main/java/com/baeldung/findanelement/FindElementInAList.java @@ -1,65 +1,72 @@ package com.baeldung.findanelement; import java.util.List; +import java.util.ListIterator; import java.util.Optional; import org.apache.commons.collections4.IterableUtils; +import com.google.common.base.Predicate; import com.google.common.collect.Iterables; public class FindElementInAList { - public T findUsingIndexOf(T element, List listOfIntegers) { - int index = listOfIntegers.indexOf(element); - if (index >= 0) { - return element; - } - return null; - } + public T findUsingIndexOf(T element, List listOfIntegers) { + int index = listOfIntegers.indexOf(element); + if (index >= 0) { + return element; + } + return null; + } - public T findUsingNormalForLoop(T element, List listOfIntegers) { - for (int i = 0; i < listOfIntegers.size(); i++) { - if (listOfIntegers.get(i).equals(element)) { - return listOfIntegers.get(i); - } - } - return null; - } + public T findUsingListIterator(T element, List listOfIntegers) { + ListIterator listIterator = listOfIntegers.listIterator(); + while (listIterator.hasNext()) { + T elementFromList = listIterator.next(); + if (elementFromList.equals(element)) { + return element; + } + } + return null; + } - public T findUsingEnhancedForLoop(T element, List listOfIntegers) { - for (T elementFromList : listOfIntegers) { - if (element.equals(elementFromList)) { - return elementFromList; - } - } - return null; - } + public T findUsingEnhancedForLoop(T element, List listOfIntegers) { + for (T elementFromList : listOfIntegers) { + if (element.equals(elementFromList)) { + return elementFromList; + } + } + return null; + } - public T findUsingStream(T element, List listOfIntegers) { - Optional foundElement = listOfIntegers - .stream() - .filter(integer -> integer.equals(element)) - .findFirst(); - return foundElement.isPresent() ? foundElement.get() : null; - } + public T findUsingStream(T element, List listOfIntegers) { + Optional foundElement = listOfIntegers.stream() + .filter(integer -> integer.equals(element)) + .findFirst(); + return foundElement.isPresent() ? foundElement.get() : null; + } - public T findUsingParallelStream(T element, List listOfIntegers) { - Optional foundElement = listOfIntegers - .parallelStream() - .filter(integer -> integer.equals(element)) - .findAny(); - return foundElement.isPresent() ? foundElement.get() : null; - } + public T findUsingParallelStream(T element, List listOfIntegers) { + Optional foundElement = listOfIntegers.parallelStream() + .filter(integer -> integer.equals(element)) + .findAny(); + return foundElement.isPresent() ? foundElement.get() : null; + } - public T findUsingGuava(T element, List listOfIntegers) { - T foundElement = Iterables - .tryFind(listOfIntegers, currentelement -> currentelement.equals(element)) - .orNull(); - return foundElement; - } + public T findUsingGuava(T element, List listOfIntegers) { + T foundElement = Iterables.tryFind(listOfIntegers, new Predicate() { + public boolean apply(T input) { + return element.equals(input); + } + }).orNull(); + return foundElement; + } - public T findUsingApacheCommon(T element, List listOfIntegers) { - T foundElement = IterableUtils - .find(listOfIntegers, currentelement -> currentelement.equals(element)); - return foundElement; - } + public T findUsingApacheCommon(T element, List listOfIntegers) { + T foundElement = IterableUtils.find(listOfIntegers, new org.apache.commons.collections4.Predicate() { + public boolean evaluate(T input) { + return element.equals(input); + } + }); + return foundElement; + } } \ No newline at end of file diff --git a/core-java-8/src/test/java/com/baeldung/findanelement/FindAnElementTest.java b/core-java-8/src/test/java/com/baeldung/findanelement/FindAnElementTest.java index e8453129f5d5..e8154499b0a4 100644 --- a/core-java-8/src/test/java/com/baeldung/findanelement/FindAnElementTest.java +++ b/core-java-8/src/test/java/com/baeldung/findanelement/FindAnElementTest.java @@ -8,110 +8,109 @@ public class FindAnElementTest { - private static List listOfIntegers = new ArrayList<>(); - static { - listOfIntegers.add(new Integer(0)); - listOfIntegers.add(new Integer(1)); - listOfIntegers.add(new Integer(2)); - } - - private static FindElementInAList findElementInAList = new FindElementInAList<>(); - - @Test - public void givenElement_whenFoundUsingIndexOf_thenReturnElement() { - Integer element = new Integer(1); - Integer foundElement = findElementInAList.findUsingIndexOf(element, listOfIntegers); - assertTrue(foundElement.equals(element)); - } - - @Test - public void givenElement_whenNotFoundUsingIndexOf_thenReturnNull() { - Integer foundElement = findElementInAList.findUsingIndexOf(new Integer(5), listOfIntegers); - assertNull(foundElement); - } - - @Test - public void givenElement_whenFoundUsingNormalForLoop_thenReturnElement() { - Integer element = new Integer(1); - Integer foundElement = findElementInAList.findUsingNormalForLoop(element, listOfIntegers); - assertTrue(foundElement.equals(element)); - } - - @Test - public void givenElement_whenNotFoundUsingNormalForLoop_thenReturnNull() { - Integer element = new Integer(5); - Integer foundElement = findElementInAList.findUsingNormalForLoop(element, listOfIntegers); - assertNull(foundElement); - } - - @Test - public void givenElement_whenFoundUsingEnhancedForLoop_thenReturnElement() { - Integer element = new Integer(1); - Integer foundElement = findElementInAList.findUsingEnhancedForLoop(element, listOfIntegers); - assertTrue(foundElement.equals(element)); - } - - @Test - public void givenElement_whenNotFoundUsingEnhancedForLoop_thenReturnNull() { - Integer element = new Integer(5); - Integer foundElement = findElementInAList.findUsingEnhancedForLoop(element, listOfIntegers); - assertNull(foundElement); - } - - @Test - public void givenElement_whenFoundUsingStream_thenReturnElement() { - Integer element = new Integer(1); - Integer foundElement = findElementInAList.findUsingStream(element, listOfIntegers); - assertTrue(foundElement.equals(element)); - } - - @Test - public void givenElement_whenNotFoundUsingStream_thenReturnNull() { - Integer element = new Integer(5); - Integer foundElement = findElementInAList.findUsingStream(element, listOfIntegers); - assertNull(foundElement); - } - - @Test - public void givenElement_whenFoundUsingParallelStream_thenReturnElement() { - Integer element = new Integer(1); - Integer foundElement = findElementInAList.findUsingParallelStream(element, listOfIntegers); - assertTrue(foundElement.equals(element)); - } - - @Test - public void givenElement_whenNotFoundUsingParallelStream_thenReturnNull() { - Integer element = new Integer(5); - Integer foundElement = findElementInAList.findUsingParallelStream(element, listOfIntegers); - assertNull(foundElement); - } - - @Test - public void givenElement_whenFoundUsingGuava_thenReturnElement() { - Integer element = new Integer(1); - Integer foundElement = findElementInAList.findUsingGuava(element, listOfIntegers); - assertTrue(foundElement.equals(element)); - } - - @Test - public void givenElement_whenNotFoundUsingGuava_thenReturnNull() { - Integer element = new Integer(5); - Integer foundElement = findElementInAList.findUsingGuava(element, listOfIntegers); - assertNull(foundElement); - } - - @Test - public void givenElement_whenFoundUsingApacheCommons_thenReturnElement() { - Integer element = new Integer(1); - Integer foundElement = findElementInAList.findUsingApacheCommon(element, listOfIntegers); - assertTrue(foundElement.equals(element)); - } - - @Test - public void givenElement_whenNotFoundUsingApacheCommons_thenReturnNull() { - Integer element = new Integer(5); - Integer foundElement = findElementInAList.findUsingApacheCommon(element, listOfIntegers); - assertNull(foundElement); - } + private static List scores = new ArrayList<>(); + static { + scores.add(new Integer(0)); + scores.add(new Integer(1)); + scores.add(new Integer(2)); + } + + private static FindElementInAList findElementInAList = new FindElementInAList<>(); + + @Test + public void givenElement_whenFoundUsingIndexOf_thenReturnElement() { + Integer scoreToFind = new Integer(1); + Integer score = findElementInAList.findUsingIndexOf(scoreToFind, scores); + assertTrue(score.equals(scoreToFind)); + } + + @Test + public void givenElement_whenNotFoundUsingListIterator_thenReturnNull() { + Integer score = findElementInAList.findUsingListIterator(new Integer(5), scores); + assertNull(score); + } + + @Test + public void givenElement_whenFoundListIterator_thenReturnElement() { + Integer scoreToFind = new Integer(1); + Integer score = findElementInAList.findUsingListIterator(scoreToFind, scores); + assertTrue(score.equals(scoreToFind)); + } + + @Test + public void givenElement_whenNotFoundUsingIndexOf_thenReturnNull() { + Integer score = findElementInAList.findUsingIndexOf(new Integer(5), scores); + assertNull(score); + } + + @Test + public void givenElement_whenFoundUsingEnhancedForLoop_thenReturnElement() { + Integer scoreToFind = new Integer(1); + Integer score = findElementInAList.findUsingEnhancedForLoop(scoreToFind, scores); + assertTrue(score.equals(scoreToFind)); + } + + @Test + public void givenElement_whenNotFoundUsingEnhancedForLoop_thenReturnNull() { + Integer scoreToFind = new Integer(5); + Integer score = findElementInAList.findUsingEnhancedForLoop(scoreToFind, scores); + assertNull(score); + } + + @Test + public void givenElement_whenFoundUsingStream_thenReturnElement() { + Integer scoreToFind = new Integer(1); + Integer score = findElementInAList.findUsingStream(scoreToFind, scores); + assertTrue(score.equals(scoreToFind)); + } + + @Test + public void givenElement_whenNotFoundUsingStream_thenReturnNull() { + Integer scoreToFind = new Integer(5); + Integer score = findElementInAList.findUsingStream(scoreToFind, scores); + assertNull(score); + } + + @Test + public void givenElement_whenFoundUsingParallelStream_thenReturnElement() { + Integer scoreToFind = new Integer(1); + Integer score = findElementInAList.findUsingParallelStream(scoreToFind, scores); + assertTrue(score.equals(scoreToFind)); + } + + @Test + public void givenElement_whenNotFoundUsingParallelStream_thenReturnNull() { + Integer scoreToFind = new Integer(5); + Integer score = findElementInAList.findUsingParallelStream(scoreToFind, scores); + assertNull(score); + } + + @Test + public void givenElement_whenFoundUsingGuava_thenReturnElement() { + Integer scoreToFind = new Integer(1); + Integer score = findElementInAList.findUsingGuava(scoreToFind, scores); + assertTrue(score.equals(scoreToFind)); + } + + @Test + public void givenElement_whenNotFoundUsingGuava_thenReturnNull() { + Integer scoreToFind = new Integer(5); + Integer score = findElementInAList.findUsingGuava(scoreToFind, scores); + assertNull(score); + } + + @Test + public void givenElement_whenFoundUsingApacheCommons_thenReturnElement() { + Integer scoreToFind = new Integer(1); + Integer score = findElementInAList.findUsingApacheCommon(scoreToFind, scores); + assertTrue(score.equals(scoreToFind)); + } + + @Test + public void givenElement_whenNotFoundUsingApacheCommons_thenReturnNull() { + Integer scoreToFind = new Integer(5); + Integer score = findElementInAList.findUsingApacheCommon(scoreToFind, scores); + assertNull(score); + } } \ No newline at end of file From 7c1523b61be48b192db11a3debf4a1241a090573 Mon Sep 17 00:00:00 2001 From: aagarwal Date: Tue, 27 Feb 2018 20:45:06 +0530 Subject: [PATCH 3/4] Updated as per Suggestions from Josh, for BAEL-1584 --- .../findanelement/FindElementInAList.java | 37 +++++++++---------- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/core-java-8/src/main/java/com/baeldung/findanelement/FindElementInAList.java b/core-java-8/src/main/java/com/baeldung/findanelement/FindElementInAList.java index a8368188a16f..0d17be338041 100644 --- a/core-java-8/src/main/java/com/baeldung/findanelement/FindElementInAList.java +++ b/core-java-8/src/main/java/com/baeldung/findanelement/FindElementInAList.java @@ -2,23 +2,22 @@ import java.util.List; import java.util.ListIterator; -import java.util.Optional; import org.apache.commons.collections4.IterableUtils; import com.google.common.base.Predicate; import com.google.common.collect.Iterables; public class FindElementInAList { - public T findUsingIndexOf(T element, List listOfIntegers) { - int index = listOfIntegers.indexOf(element); + public T findUsingIndexOf(T element, List list) { + int index = list.indexOf(element); if (index >= 0) { return element; } return null; } - public T findUsingListIterator(T element, List listOfIntegers) { - ListIterator listIterator = listOfIntegers.listIterator(); + public T findUsingListIterator(T element, List list) { + ListIterator listIterator = list.listIterator(); while (listIterator.hasNext()) { T elementFromList = listIterator.next(); if (elementFromList.equals(element)) { @@ -28,8 +27,8 @@ public T findUsingListIterator(T element, List listOfIntegers) { return null; } - public T findUsingEnhancedForLoop(T element, List listOfIntegers) { - for (T elementFromList : listOfIntegers) { + public T findUsingEnhancedForLoop(T element, List list) { + for (T elementFromList : list) { if (element.equals(elementFromList)) { return elementFromList; } @@ -37,22 +36,22 @@ public T findUsingEnhancedForLoop(T element, List listOfIntegers) { return null; } - public T findUsingStream(T element, List listOfIntegers) { - Optional foundElement = listOfIntegers.stream() + public T findUsingStream(T element, List list) { + return list.stream() .filter(integer -> integer.equals(element)) - .findFirst(); - return foundElement.isPresent() ? foundElement.get() : null; + .findFirst() + .orElse(null); } - public T findUsingParallelStream(T element, List listOfIntegers) { - Optional foundElement = listOfIntegers.parallelStream() + public T findUsingParallelStream(T element, List list) { + return list.parallelStream() .filter(integer -> integer.equals(element)) - .findAny(); - return foundElement.isPresent() ? foundElement.get() : null; + .findAny() + .orElse(null); } - public T findUsingGuava(T element, List listOfIntegers) { - T foundElement = Iterables.tryFind(listOfIntegers, new Predicate() { + public T findUsingGuava(T element, List list) { + T foundElement = Iterables.tryFind(list, new Predicate() { public boolean apply(T input) { return element.equals(input); } @@ -60,8 +59,8 @@ public boolean apply(T input) { return foundElement; } - public T findUsingApacheCommon(T element, List listOfIntegers) { - T foundElement = IterableUtils.find(listOfIntegers, new org.apache.commons.collections4.Predicate() { + public T findUsingApacheCommon(T element, List list) { + T foundElement = IterableUtils.find(list, new org.apache.commons.collections4.Predicate() { public boolean evaluate(T input) { return element.equals(input); } From d6fe46f4d7ac6b445bfe58696cc8cc0c4efca1b1 Mon Sep 17 00:00:00 2001 From: aagarwal Date: Wed, 7 Mar 2018 19:19:00 +0530 Subject: [PATCH 4/4] Removed wrapper class and updated few methods to return boolean instead of Integer --- .../findanelement/FindElementInAList.java | 12 ++--- .../findanelement/FindAnElementTest.java | 48 +++++++++---------- 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/core-java-8/src/main/java/com/baeldung/findanelement/FindElementInAList.java b/core-java-8/src/main/java/com/baeldung/findanelement/FindElementInAList.java index 0d17be338041..2f402ee72bd2 100644 --- a/core-java-8/src/main/java/com/baeldung/findanelement/FindElementInAList.java +++ b/core-java-8/src/main/java/com/baeldung/findanelement/FindElementInAList.java @@ -16,24 +16,24 @@ public T findUsingIndexOf(T element, List list) { return null; } - public T findUsingListIterator(T element, List list) { + public boolean findUsingListIterator(T element, List list) { ListIterator listIterator = list.listIterator(); while (listIterator.hasNext()) { T elementFromList = listIterator.next(); if (elementFromList.equals(element)) { - return element; + return true; } } - return null; + return false; } - public T findUsingEnhancedForLoop(T element, List list) { + public boolean findUsingEnhancedForLoop(T element, List list) { for (T elementFromList : list) { if (element.equals(elementFromList)) { - return elementFromList; + return true; } } - return null; + return false; } public T findUsingStream(T element, List list) { diff --git a/core-java-8/src/test/java/com/baeldung/findanelement/FindAnElementTest.java b/core-java-8/src/test/java/com/baeldung/findanelement/FindAnElementTest.java index e8154499b0a4..1fef2d98e7ee 100644 --- a/core-java-8/src/test/java/com/baeldung/findanelement/FindAnElementTest.java +++ b/core-java-8/src/test/java/com/baeldung/findanelement/FindAnElementTest.java @@ -10,105 +10,105 @@ public class FindAnElementTest { private static List scores = new ArrayList<>(); static { - scores.add(new Integer(0)); - scores.add(new Integer(1)); - scores.add(new Integer(2)); + scores.add(0); + scores.add(1); + scores.add(2); } private static FindElementInAList findElementInAList = new FindElementInAList<>(); @Test public void givenElement_whenFoundUsingIndexOf_thenReturnElement() { - Integer scoreToFind = new Integer(1); + Integer scoreToFind = 1; Integer score = findElementInAList.findUsingIndexOf(scoreToFind, scores); assertTrue(score.equals(scoreToFind)); } @Test public void givenElement_whenNotFoundUsingListIterator_thenReturnNull() { - Integer score = findElementInAList.findUsingListIterator(new Integer(5), scores); - assertNull(score); + boolean found = findElementInAList.findUsingListIterator(5, scores); + assertTrue(!found); } @Test public void givenElement_whenFoundListIterator_thenReturnElement() { - Integer scoreToFind = new Integer(1); - Integer score = findElementInAList.findUsingListIterator(scoreToFind, scores); - assertTrue(score.equals(scoreToFind)); + Integer scoreToFind = 1; + boolean found = findElementInAList.findUsingListIterator(scoreToFind, scores); + assertTrue(found); } @Test public void givenElement_whenNotFoundUsingIndexOf_thenReturnNull() { - Integer score = findElementInAList.findUsingIndexOf(new Integer(5), scores); + Integer score = findElementInAList.findUsingIndexOf(5, scores); assertNull(score); } @Test public void givenElement_whenFoundUsingEnhancedForLoop_thenReturnElement() { - Integer scoreToFind = new Integer(1); - Integer score = findElementInAList.findUsingEnhancedForLoop(scoreToFind, scores); - assertTrue(score.equals(scoreToFind)); + Integer scoreToFind = 1; + boolean found = findElementInAList.findUsingEnhancedForLoop(scoreToFind, scores); + assertTrue(found); } @Test public void givenElement_whenNotFoundUsingEnhancedForLoop_thenReturnNull() { - Integer scoreToFind = new Integer(5); - Integer score = findElementInAList.findUsingEnhancedForLoop(scoreToFind, scores); - assertNull(score); + Integer scoreToFind = 5; + boolean found = findElementInAList.findUsingEnhancedForLoop(scoreToFind, scores); + assertTrue(!found); } @Test public void givenElement_whenFoundUsingStream_thenReturnElement() { - Integer scoreToFind = new Integer(1); + Integer scoreToFind = 1; Integer score = findElementInAList.findUsingStream(scoreToFind, scores); assertTrue(score.equals(scoreToFind)); } @Test public void givenElement_whenNotFoundUsingStream_thenReturnNull() { - Integer scoreToFind = new Integer(5); + Integer scoreToFind = 5; Integer score = findElementInAList.findUsingStream(scoreToFind, scores); assertNull(score); } @Test public void givenElement_whenFoundUsingParallelStream_thenReturnElement() { - Integer scoreToFind = new Integer(1); + Integer scoreToFind = 1; Integer score = findElementInAList.findUsingParallelStream(scoreToFind, scores); assertTrue(score.equals(scoreToFind)); } @Test public void givenElement_whenNotFoundUsingParallelStream_thenReturnNull() { - Integer scoreToFind = new Integer(5); + Integer scoreToFind = 5; Integer score = findElementInAList.findUsingParallelStream(scoreToFind, scores); assertNull(score); } @Test public void givenElement_whenFoundUsingGuava_thenReturnElement() { - Integer scoreToFind = new Integer(1); + Integer scoreToFind = 1; Integer score = findElementInAList.findUsingGuava(scoreToFind, scores); assertTrue(score.equals(scoreToFind)); } @Test public void givenElement_whenNotFoundUsingGuava_thenReturnNull() { - Integer scoreToFind = new Integer(5); + Integer scoreToFind = 5; Integer score = findElementInAList.findUsingGuava(scoreToFind, scores); assertNull(score); } @Test public void givenElement_whenFoundUsingApacheCommons_thenReturnElement() { - Integer scoreToFind = new Integer(1); + Integer scoreToFind = 1; Integer score = findElementInAList.findUsingApacheCommon(scoreToFind, scores); assertTrue(score.equals(scoreToFind)); } @Test public void givenElement_whenNotFoundUsingApacheCommons_thenReturnNull() { - Integer scoreToFind = new Integer(5); + Integer scoreToFind = 5; Integer score = findElementInAList.findUsingApacheCommon(scoreToFind, scores); assertNull(score); }