From b1e230de41f1abb7bd963c5ed9815257c4e3c91b Mon Sep 17 00:00:00 2001 From: Marcos Lopez Gonzalez Date: Tue, 10 Apr 2018 22:16:50 +0200 Subject: [PATCH] arrayList * shorter tests names --- .../junit4/BeforeAndAfterAnnotationsTest.java | 11 ++++------- .../junit5/BeforeEachAndAfterEachAnnotationsTest.java | 11 ++++------- 2 files changed, 8 insertions(+), 14 deletions(-) diff --git a/testing-modules/junit-5/src/test/java/com/baeldung/migration/junit4/BeforeAndAfterAnnotationsTest.java b/testing-modules/junit-5/src/test/java/com/baeldung/migration/junit4/BeforeAndAfterAnnotationsTest.java index 305c7a8442c0..e26b10e7e596 100644 --- a/testing-modules/junit-5/src/test/java/com/baeldung/migration/junit4/BeforeAndAfterAnnotationsTest.java +++ b/testing-modules/junit-5/src/test/java/com/baeldung/migration/junit4/BeforeAndAfterAnnotationsTest.java @@ -3,6 +3,7 @@ import static org.junit.Assert.assertEquals; import java.util.ArrayList; +import java.util.Arrays; import java.util.List; import org.junit.After; @@ -23,21 +24,17 @@ public class BeforeAndAfterAnnotationsTest { @Before public void init() { LOG.info("startup"); - - list = new ArrayList<>(); - list.add("test1"); - list.add("test2"); + list = new ArrayList<>(Arrays.asList("test1", "test2")); } @After public void finalize() { LOG.info("finalize"); - list.clear(); } @Test - public void whenCheckingListSizeAtBeginning_ThenSizeEqualsToStartupSize() { + public void whenCheckingListSize_ThenSizeEqualsToInit() { LOG.info("executing test"); assertEquals(2, list.size()); @@ -45,7 +42,7 @@ public void whenCheckingListSizeAtBeginning_ThenSizeEqualsToStartupSize() { } @Test - public void whenCheckingListSizeAtBeginningAgain_ThenSizeEqualsToStartupSize() { + public void whenCheckingListSizeAgain_ThenSizeEqualsToInit() { LOG.info("executing another test"); assertEquals(2, list.size()); diff --git a/testing-modules/junit-5/src/test/java/com/baeldung/migration/junit5/BeforeEachAndAfterEachAnnotationsTest.java b/testing-modules/junit-5/src/test/java/com/baeldung/migration/junit5/BeforeEachAndAfterEachAnnotationsTest.java index 9785303b4800..6302992a5b2a 100644 --- a/testing-modules/junit-5/src/test/java/com/baeldung/migration/junit5/BeforeEachAndAfterEachAnnotationsTest.java +++ b/testing-modules/junit-5/src/test/java/com/baeldung/migration/junit5/BeforeEachAndAfterEachAnnotationsTest.java @@ -3,6 +3,7 @@ import static org.junit.Assert.assertEquals; import java.util.ArrayList; +import java.util.Arrays; import java.util.List; import org.junit.jupiter.api.AfterEach; @@ -23,21 +24,17 @@ public class BeforeEachAndAfterEachAnnotationsTest { @BeforeEach public void init() { LOG.info("startup"); - - list = new ArrayList<>(); - list.add("test1"); - list.add("test2"); + list = new ArrayList<>(Arrays.asList("test1", "test2")); } @AfterEach public void finalize() { LOG.info("finalize"); - list.clear(); } @Test - public void whenCheckingListSizeAtBeginning_ThenSizeEqualsToStartupSize() { + public void whenCheckingListSize_ThenSizeEqualsToInit() { LOG.info("executing test"); assertEquals(2, list.size()); @@ -45,7 +42,7 @@ public void whenCheckingListSizeAtBeginning_ThenSizeEqualsToStartupSize() { } @Test - public void whenCheckingListSizeAtBeginningAgain_ThenSizeEqualsToStartupSize() { + public void whenCheckingListSizeAgain_ThenSizeEqualsToInit() { LOG.info("executing another test"); assertEquals(2, list.size());