fix #4407: incorrect error for inject edge case

Author: evanw

CHANGELOG.md

@@ -29,6 +29,23 @@
     }
     ```
 
+* Fix an edge case with the `inject` feature ([#4407](https://github.com/evanw/esbuild/issues/4407))
+
+    This release fixes an edge case where esbuild's `inject` feature could not be used with arbitrary module namespace names exported using an `export {} from` statement with bundling disabled and a target environment where arbitrary module namespace names is unsupported.
+
+    With the fix, the following `inject` file:
+
+    ```js
+    import jquery from 'jquery';
+    export { jquery as 'window.jQuery' };
+    ```
+
+    Can now always be rewritten as this without esbuild sometimes incorrectly generating an error:
+
+    ```js
+    export { default as 'window.jQuery' } from 'jquery';
+    ```
+
 ## 0.27.3
 
 * Preserve URL fragments in data URLs ([#4370](https://github.com/evanw/esbuild/issues/4370))

internal/bundler_tests/bundler_default_test.go

@@ -9110,7 +9110,7 @@ func TestForbidStringExportNamesNoBundle(t *testing.T) {
 			UnsupportedJSFeatures: compat.ArbitraryModuleNamespaceNames,
 		},
 		expectedCompileLog: `entry.js: ERROR: Using the string "not ok" as an export name is not supported in the configured target environment
-entry.js: ERROR: Using the string "same name" as an export name is not supported in the configured target environment
+entry.js: ERROR: Using the string "same name" as an import name is not supported in the configured target environment
 entry.js: ERROR: Using the string "name 1" as an import name is not supported in the configured target environment
 entry.js: ERROR: Using the string "name 2" as an export name is not supported in the configured target environment
 entry.js: ERROR: Using the string "name space" as an export name is not supported in the configured target environment
@@ -9232,6 +9232,26 @@ func TestInjectWithStringExportNameBundle(t *testing.T) {
 	})
 }
 
+func TestInjectWithStringReExportNameNoBundle(t *testing.T) {
+	default_suite.expectBundled(t, bundled{
+		files: map[string]string{
+			"/entry.js": `
+				console.log(test)
+			`,
+			"/inject.js": `
+				export { fn as "console.log" } from 'pkg'
+			`,
+		},
+		entryPaths: []string{"/entry.js"},
+		options: config.Options{
+			Mode:                  config.ModePassThrough,
+			AbsOutputFile:         "/out.js",
+			InjectPaths:           []string{"/inject.js"},
+			UnsupportedJSFeatures: compat.ArbitraryModuleNamespaceNames,
+		},
+	})
+}
+
 func TestStringExportNamesCommonJS(t *testing.T) {
 	default_suite.expectBundled(t, bundled{
 		files: map[string]string{

internal/bundler_tests/snapshots/snapshots_default.txt

@@ -2249,6 +2249,12 @@ var old = console.log;
 var fn = (...args) => old.apply(console, ["log:"].concat(args));
 fn(test);
 
+================================================================================
+TestInjectWithStringReExportNameNoBundle
+---------- /out.js ----------
+import { fn } from "pkg";
+fn(test);
+
 ================================================================================
 TestJSXAutomaticImportsCommonJS
 ---------- /out.js ----------

internal/linker/linker.go

@@ -4467,10 +4467,7 @@ func (c *linkerContext) convertStmtsForChunk(sourceIndex uint32, stmtList *stmtL
 
 			if c.options.UnsupportedJSFeatures.Has(compat.ArbitraryModuleNamespaceNames) {
 				for _, item := range s.Items {
-					c.maybeForbidArbitraryModuleNamespaceIdentifier("export", sourceIndex, item.AliasLoc, item.Alias)
-					if item.AliasLoc != item.Name.Loc {
-						c.maybeForbidArbitraryModuleNamespaceIdentifier("import", sourceIndex, item.Name.Loc, item.OriginalName)
-					}
+					c.maybeForbidArbitraryModuleNamespaceIdentifier("import", sourceIndex, item.Name.Loc, item.OriginalName)
 				}
 			}
 
@@ -4485,6 +4482,12 @@ func (c *linkerContext) convertStmtsForChunk(sourceIndex uint32, stmtList *stmtL
 					ImportRecordIndex: s.ImportRecordIndex,
 					IsSingleLine:      s.IsSingleLine,
 				}
+			} else if c.options.UnsupportedJSFeatures.Has(compat.ArbitraryModuleNamespaceNames) {
+				for _, item := range s.Items {
+					if item.AliasLoc != item.Name.Loc {
+						c.maybeForbidArbitraryModuleNamespaceIdentifier("export", sourceIndex, item.AliasLoc, item.Alias)
+					}
+				}
 			}
 
 			// Make sure these don't end up in the wrapper closure