Skip to content

Commit 2222497

Browse files
authored
⏮ e2e: Revert some recent e2e fixes (#421)
Revert some recent e2e fixes around share dialog snapshot tests. Revert the removed pixel difference threshhold in one test. However, the previously added ios tests seem to be ok, so we will leave them in. It is unclear how these tests passed on PR CI and but do not pass on main CI despite 3 re-runs. I somewhat consistently could reproduce the issue locally with: BASEURL='https://evy.dev' make e2e USE_DOCKER=1 Against localhost / without BASEURL the issue never shows up for me even when run with docker. However, I had another unrelated issue show up quite frequently too in the docs tests which seems to be addressed with an extra wait for network idle. I will keep the docs tests fix in place. I also suspected that once tests pass once it is harder to get them to fail again, which would explain why we didn't see the issue on the PR before. I'm not sure if this makes any sense at all. Related-Pull-Request: #420 Related-Commit: b8f0fdf Pull-request: #421
1 parent 880955b commit 2222497

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

e2e/docs/test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ for (const baseURL of baseURLs) {
6464
await link.hover()
6565
await expect(page).toHaveScreenshot("comment-hover.png", sreenshotOpts)
6666
await link.click()
67+
await page.waitForLoadState("networkidle")
6768
await expect(page).toHaveScreenshot("comment-page.png", sreenshotOpts)
6869
})
6970

e2e/play/test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ end
9191
}
9292
await page.locator('input[type="text"]').click()
9393
await page.locator('input[type="text"]').press("ArrowRight")
94-
await expect(page).toHaveScreenshot("share-dialog.png")
94+
await expect(page).toHaveScreenshot("share-dialog.png", { maxDiffPixelRatio: 0.01 })
9595
await page.locator("#dialog-share .icon-close").click()
9696
await expect(page).toHaveScreenshot("no-dialog.png")
9797
await page.locator("#hamburger").click()

0 commit comments

Comments
 (0)