Make the tests pass with Sphinx 7.2#5
Closed
mitya57 wants to merge 1 commit into
Closed
Conversation
Starting with Sphinx 7.2, SphinxTestApp constructor expects srcdir to
be pathlib.Path. Otherwise, the following error happens:
> outdir.mkdir(parents=True, exist_ok=True)
E AttributeError: 'path' object has no attribute 'mkdir'
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
Contributor
|
Hi @mitya57, thanks for authoring this PR! I'm going to close it in favour of #6, because we've had to make these changes in other parts of the stack and I'm trying to keep them fairly identical. But, your contribution is highly appreciated; if we hadn't had to make this change already, it would have been an immediate merge! Thanks, and please don't hesitate to contribute again - we need these kinds of improvements! <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with Sphinx 7.2, SphinxTestApp constructor expects
srcdirto be pathlib.Path. Otherwise, the following error happens: