Skip to content

Make the tests pass with Sphinx 7.2#5

Closed
mitya57 wants to merge 1 commit into
executablebooks:mainfrom
mitya57:sphinx-7.2
Closed

Make the tests pass with Sphinx 7.2#5
mitya57 wants to merge 1 commit into
executablebooks:mainfrom
mitya57:sphinx-7.2

Conversation

@mitya57
Copy link
Copy Markdown

@mitya57 mitya57 commented Nov 3, 2023

Starting with Sphinx 7.2, SphinxTestApp constructor expects srcdir to be pathlib.Path. Otherwise, the following error happens:

>       outdir.mkdir(parents=True, exist_ok=True)
E       AttributeError: 'path' object has no attribute 'mkdir'

Starting with Sphinx 7.2, SphinxTestApp constructor expects srcdir to
be pathlib.Path. Otherwise, the following error happens:

    >       outdir.mkdir(parents=True, exist_ok=True)
    E       AttributeError: 'path' object has no attribute 'mkdir'
@welcome
Copy link
Copy Markdown

welcome Bot commented Nov 3, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@agoose77
Copy link
Copy Markdown
Contributor

Hi @mitya57, thanks for authoring this PR! I'm going to close it in favour of #6, because we've had to make these changes in other parts of the stack and I'm trying to keep them fairly identical.

But, your contribution is highly appreciated; if we hadn't had to make this change already, it would have been an immediate merge!

Thanks, and please don't hesitate to contribute again - we need these kinds of improvements! <3

@agoose77 agoose77 closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants