Queen attack#970
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
mk-mxp
added
x:action/sync
| ]); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
All changes to this file should not be in this pull request. Please update your fork to the current version of main and rebase your git branch. That should revert changes to this file.
There was a problem hiding this comment.
Oh wow, sorry about this, thank you
| public function testQueenHasPositiveRank(): void | ||
| { | ||
| $this->expectException(InvalidArgumentException::class); | ||
| $this->expectExceptionMessage('The rank and file numbers must be positive.'); |
There was a problem hiding this comment.
Please remove the tests on exception messages from all tests:
Co-authored-by: mk-mxp <55182845+mk-mxp@users.noreply.github.com>
Co-authored-by: mk-mxp <55182845+mk-mxp@users.noreply.github.com>
Co-authored-by: mk-mxp <55182845+mk-mxp@users.noreply.github.com>
2 participants
This pull request does the following:
Sync test files and meta data to problem specification
Drop strict types comments from test file and example code
Add and sync test meta data to tests (uuid in DocBlocks / #TestDox())
Add exercise to bin/auto-sync.txt to keep it in sync (keep the file alphabetically sorted)
Adding / adjust / ordering test cases to match current problem specs
Add missing test case