Ignore requests without "url" property

Author: dougwilson

HISTORY.md

@@ -1,6 +1,7 @@
 unreleased
 ==========
 
+  * Ignore requests without `url` property
   * deps: ms@2.1.1
     - Add `week`
     - Add `w`

index.js

@@ -64,7 +64,7 @@ function favicon (path, options) {
   }
 
   return function favicon (req, res, next) {
-    if (parseUrl(req).pathname !== '/favicon.ico') {
+    if (getPathname(req) !== '/favicon.ico') {
       next()
       return
     }
@@ -144,6 +144,21 @@ function createIsDirError (path) {
   return error
 }
 
+/**
+ * Get the request pathname.
+ *
+ * @param {object} req
+ * @return {string}
+ */
+
+function getPathname (req) {
+  try {
+    return parseUrl(req).pathname
+  } catch (e) {
+    return undefined
+  }
+}
+
 /**
  * Determine if the cached representation is fresh.
  *

test/test.js

@@ -183,6 +183,13 @@ describe('favicon()', function () {
       .expect('Content-Type', 'image/x-icon')
       .expect(200, done)
     })
+
+    describe('missing req.url', function () {
+      it('should ignore the request', function (done) {
+        var fn = favicon(ICON_PATH)
+        fn({}, {}, done)
+      })
+    })
   })
 
   describe('icon', function () {