Skip to content

Respect dx/dy attributes and calculate node position more precisely#515

Merged
ystrot merged 1 commit intoexyte:masterfrom
vahotm:master
Dec 27, 2018
Merged

Respect dx/dy attributes and calculate node position more precisely#515
ystrot merged 1 commit intoexyte:masterfrom
vahotm:master

Conversation

@vahotm
Copy link

@vahotm vahotm commented Dec 26, 2018

Usually multiline text is represented by multiple tspans, one for each line, and every tspan except the first one is positioned using dx and dy offsets. Although this fix doesn't fully support all dx/dy values, allowed in SVG by HTML 5 standard, such as number sequence, but still allows better rendering for multiline text.

@amarunko amarunko added the SVG label Dec 26, 2018
@ystrot ystrot added this to the 0.9.4 milestone Dec 27, 2018
@ystrot ystrot self-assigned this Dec 27, 2018
@ystrot ystrot merged commit b416165 into exyte:master Dec 27, 2018
@ystrot
Copy link
Member

ystrot commented Dec 27, 2018

Thank you for the fix! Merged it into the master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants