Respect dx/dy attributes and calculate node position more precisely#515
Merged
ystrot merged 1 commit intoexyte:masterfrom Dec 27, 2018
Merged
Respect dx/dy attributes and calculate node position more precisely#515ystrot merged 1 commit intoexyte:masterfrom
ystrot merged 1 commit intoexyte:masterfrom
Conversation
ystrot
approved these changes
Dec 27, 2018
Member
|
Thank you for the fix! Merged it into the master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usually multiline text is represented by multiple tspans, one for each line, and every tspan except the first one is positioned using dx and dy offsets. Although this fix doesn't fully support all dx/dy values, allowed in SVG by HTML 5 standard, such as number sequence, but still allows better rendering for multiline text.