Skip to content

Fix ejecting from a scoped fork #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 3 commits into from
Mar 5, 2017
Merged

Fix ejecting from a scoped fork #1727

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e91218f
Fix ejecting for a scoped react-scripts fork
gaearon Mar 5, 2017
991714f
Clarify that own* properties only exist before ejecting
gaearon Mar 5, 2017
55fccd8
Read script names from own bin instead of guessing
gaearon Mar 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix ejecting for a scoped react-scripts fork 
We shouldn't hardcode react-scripts because fork name might differ.
We also shouldn't rely on it being an immediate child because scoped packages are a level deeper.
  • Loading branch information
@gaearon
gaearon committed Mar 5, 2017
commit e91218f662a448d7d6ce29914b43541da5c8bb95
2 changes: 1 addition & 1 deletion packages/react-scripts/config/paths.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ function resolveOwn(relativePath) {
// config before eject: we're in ./node_modules/react-scripts/config/
module.exports = {
appPath: resolveApp('.'),
ownPath: resolveApp('node_modules/react-scripts'),
ownPath: resolveOwn('.'),
appBuild: resolveApp('build'),
appPublic: resolveApp('public'),
appHtml: resolveApp('public/index.html'),
Expand Down