Deprecate removeListener APIs#2578
Merged
Merged
Conversation
yungsters
changed the title
removeListeners APIsremoveListener APIs
yungsters
force-pushed
the
deprecate-removelisteners-docs
branch
from
6c7c331 to
02b41e3
Compare
lunaleaps
reviewed
Apr 5, 2021
| 'screenReaderChanged', | ||
| this._handleScreenReaderToggled | ||
| ); | ||
| this.reduceMotionChangedSubscription.remove(); |
Contributor
There was a problem hiding this comment.
Is the formatting off on this?
Contributor
Author
There was a problem hiding this comment.
Whoops, yes. It is… thanks for catching that.
yungsters
force-pushed
the
deprecate-removelisteners-docs
branch
from
02b41e3 to
99f9447
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following listener removal methods are deprecated. This update the documentation to reflect this, and it update the example code to use the recommended event subscription
remove()methods.Appearance.removeChangeListenerAccessibilityInfo.removeEventListenerAppearance.removeChangeListenerAppState.removeEventListenerDimensions.removeEventListenerKeyboard.removeListenerLinking.removeEventListenerTest Plan:
Locally verified that the method is no longer documented by going to: http://localhost:3000/docs/next/scrollview#scrolltoend