Skip to content

Commit 062c1f7

Browse files
cortinicofacebook-github-bot
authored andcommitted
Unblock CI by disabling integration testing for test_ios_unit_hermes (#33128)
Summary: I'm disabling the integration test step for `test_ios_unit_hermes` as they're currently failign wiht a `SIGSEGV` introduced by 9010bfe The change is legit, but is introducing an ABI incompatibility that is making the app crash at runtime. We can re-enable them as soon as Hermes 0.12.0 is released. ## Changelog [Internal] - Unblock CI by disabling integration testing for `test_ios_unit_hermes` Pull Request resolved: #33128 Test Plan: Will wait for a Circle CI green before merging Reviewed By: neildhar Differential Revision: D34285751 Pulled By: cortinico fbshipit-source-id: 40f8e3d1b41fc4d5f0459003dcd19d651aefbeb7
1 parent b2e625a commit 062c1f7

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

.circleci/config.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -966,7 +966,10 @@ workflows:
966966
- test_ios:
967967
name: test_ios_unit_hermes
968968
use_hermes: true
969-
run_unit_tests: true
969+
# TODO(ncor, neildhar) Integration tests for iOS + Hermes are currently
970+
# disabled due to an ABI incompatibility introduced by D33830544.
971+
# They can be re-enabled as soon as Hermes 0.12.0 is released.
972+
run_unit_tests: false
970973
filters:
971974
branches:
972975
ignore: gh-pages

0 commit comments

Comments
 (0)