Delete mobile config react_fabric:finalize_updates_on_synchronous_update_view_ios

sammy-SC · facebook-github-bot · commit 2013a203fc1d · 2022-07-21T06:08:23.000-07:00
Summary:
changelog: [internal]

This was used as a kill switch, it has been in place for over 4 months, let's get rid of it.

Reviewed By: mdvacca

Differential Revision: D37921377

fbshipit-source-id: 594586033694766e13d0f2ab2bcd73b28ba180a9
diff --git a/React/Fabric/Mounting/RCTMountingManager.mm b/React/Fabric/Mounting/RCTMountingManager.mm
@@ -324,10 +324,7 @@ - (void)synchronouslyUpdateViewOnUIThread:(ReactTag)reactTag
     componentView.layer.opacity = newViewProps.opacity;
   }
 
-  auto reactNativeConfig = _contextContainer->at<std::shared_ptr<ReactNativeConfig const>>("ReactNativeConfig");
-  if (reactNativeConfig && reactNativeConfig->getBool("react_fabric:finalize_updates_on_synchronous_update_view_ios")) {
-    [componentView finalizeUpdates:RNComponentViewUpdateMaskProps];
-  }
+  [componentView finalizeUpdates:RNComponentViewUpdateMaskProps];
 }
 
 - (void)synchronouslyDispatchCommandOnUIThread:(ReactTag)reactTag

Original file line number	Diff line number	Diff line change
`@@ -324,10 +324,7 @@ - (void)synchronouslyUpdateViewOnUIThread:(ReactTag)reactTag`
`324`	`324`	`componentView.layer.opacity = newViewProps.opacity;`
`325`	`325`	`}`
`326`	`326`
`327`		`- auto reactNativeConfig = _contextContainer->at<std::shared_ptr<ReactNativeConfig const>>("ReactNativeConfig");`
`328`		`- if (reactNativeConfig && reactNativeConfig->getBool("react_fabric:finalize_updates_on_synchronous_update_view_ios")) {`
`329`		`- [componentView finalizeUpdates:RNComponentViewUpdateMaskProps];`
`330`		`- }`
	`327`	`+ [componentView finalizeUpdates:RNComponentViewUpdateMaskProps];`
`331`	`328`	`}`
`332`	`329`
`333`	`330`	`- (void)synchronouslyDispatchCommandOnUIThread:(ReactTag)reactTag`