iOS: RCTSurface needs to re-register its root view on bridge reload

fkgozali · facebook-github-bot · commit 2e51fa5f5d4f · 2018-03-06T12:48:20.000-08:00
Summary: When reloading JS during development, surface needs to make sure the root view gets re-registered before attempting to remount it. This fixes redbox on JS reload.

Reviewed By: shergin

Differential Revision: D7170416

fbshipit-source-id: c84b999d2cdc35cb9e26feef2a1e1a7ce35cfa70
diff --git a/React/Base/Surface/RCTSurface.mm b/React/Base/Surface/RCTSurface.mm
@@ -209,6 +209,7 @@ - (void)handleBridgeDidLoadJavaScriptNotification:(NSNotification *)notification
   }
 
   if (isRerunNeeded) {
+    [self _registerRootView];
     [self _run];
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -209,6 +209,7 @@ - (void)handleBridgeDidLoadJavaScriptNotification:(NSNotification *)notification`
`209`	`209`	`}`
`210`	`210`
`211`	`211`	`if (isRerunNeeded) {`
	`212`	`+ [self _registerRootView];`
`212`	`213`	`[self _run];`
`213`	`214`	`}`
`214`	`215`	`}`