Skip to content

Commit 4e5d50d

Browse files
tsjammfacebook-github-bot
authored andcommitted
Issue #16159 - RCTImageStoreManager's priority
Summary: RCTImageStoreManager and RCTBlobManager have the same priority, hence in certain cases, both are able to handle the request, but this causes non-deterministic behavior. Hence increased ImageStoreManager's Priority to 1 and thereby increasing RCTImageLoader's Priority to 2 to prevent similar issue of same priorities. Issue: #16159 Closes #16160 Differential Revision: D6017931 Pulled By: shergin fbshipit-source-id: 91f2737af4f2f97197734b696105e1cdc5683365
1 parent dbe6044 commit 4e5d50d

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

Libraries/Image/RCTImageLoader.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ - (void)setUp
6666

6767
- (float)handlerPriority
6868
{
69-
return 1;
69+
return 2;
7070
}
7171

7272
- (id<RCTImageCache>)imageCache

Libraries/Image/RCTImageStoreManager.m

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,11 @@ @implementation RCTImageStoreManager
3232

3333
RCT_EXPORT_MODULE()
3434

35+
- (float)handlerPriority
36+
{
37+
return 1;
38+
}
39+
3540
- (void)removeImageForTag:(NSString *)imageTag withBlock:(void (^)())block
3641
{
3742
dispatch_async(_methodQueue, ^{

0 commit comments

Comments
 (0)