Fixed crash happenned on deallocating RCTSurface

shergin · facebook-github-bot · commit c3139d798af6 · 2018-01-07T22:22:45.000-08:00
Summary:
Essentially, we had `dispatch_async` inside `delloc` method which tried to retain `self`, which is disallowed operation in ObjC runtime.
However, we don't need to notify anything `surface`-related in `_stop` because it always is called from `dealloc`.

Reviewed By: mmmulani

Differential Revision: D6665631

fbshipit-source-id: ed0d192946f3323f4f54ecb99b30e56e0942f174
diff --git a/React/Base/Surface/RCTSurface.mm b/React/Base/Surface/RCTSurface.mm
@@ -306,8 +306,6 @@ - (void)_stop
                         method:@"unmountApplicationComponentAtRootTag"
                           args:@[self->_rootViewTag]
                     completion:NULL];
-
-  [self _setStage:RCTSurfaceStageSurfaceDidStop];
 }
 
 - (void)_registerRootView

Original file line number	Diff line number	Diff line change
`@@ -306,8 +306,6 @@ - (void)_stop`
`306`	`306`	`method:@"unmountApplicationComponentAtRootTag"`
`307`	`307`	`args:@[self->_rootViewTag]`
`308`	`308`	`completion:NULL];`
`309`		`-`
`310`		`- [self _setStage:RCTSurfaceStageSurfaceDidStop];`
`311`	`309`	`}`
`312`	`310`
`313`	`311`	`- (void)_registerRootView`