Minor fixes to clipboard and Linking to remove TODOs

Reviewed By: nicklockwood

Differential Revision: D2921782

fb-gh-sync-id: e387b720421ed6ed03a50633d71e08791f87c761
shipit-source-id: e387b720421ed6ed03a50633d71e08791f87c761

Author: Dave Miller

Libraries/LinkingIOS/RCTLinkingManager.m

@@ -77,10 +77,8 @@ - (void)handleOpenURLNotification:(NSNotification *)notification
                   resolve:(RCTPromiseResolveBlock)resolve
                   reject:(__unused RCTPromiseRejectBlock)reject)
 {
-  // TODO: we should really report success/failure via the promise here
-  // Doesn't really matter what thread we call this on since it exits the app
-  [RCTSharedApplication() openURL:URL];
-  resolve(@YES);
+  BOOL opened = [RCTSharedApplication() openURL:URL];
+  resolve(@(opened));
 }
 
 RCT_EXPORT_METHOD(canOpenURL:(NSURL *)URL

React/Modules/RCTClipboard.m

@@ -26,14 +26,14 @@ - (dispatch_queue_t)methodQueue
 RCT_EXPORT_METHOD(setString:(NSString *)content)
 {
   UIPasteboard *clipboard = [UIPasteboard generalPasteboard];
-  clipboard.string = content;
+  clipboard.string = (content ? : @"");
 }
 
 RCT_EXPORT_METHOD(getString:(RCTPromiseResolveBlock)resolve
                   rejecter:(__unused RCTPromiseRejectBlock)reject)
 {
   UIPasteboard *clipboard = [UIPasteboard generalPasteboard];
-  resolve(RCTNullIfNil(clipboard.string));
+  resolve((clipboard.string ? : @""));
 }
 
 @end