Skip to content

Commit e509007

Browse files
kelsetfacebook-github-bot
authored andcommitted
fix(internal, dangerfile): fix changelog entries for dangerfiles and PR template (#35541)
Summary: A few days back leotm pointed out how the dangerfile was disaligned with the docs around the valid changelog entries for categories and types here: #35443 (comment) I dug a bit deeper into the whole thing and went to the source of truth, which is the changelog generator, in particular here: https://github.com/microsoft/rnx-kit/blob/main/incubator/rn-changelog-generator/src/utils/getChangeDimensions.ts So I've updated the dangerfile to respect the options listed there. Also did a parallel PR on the website side: facebook/react-native-website#3447 So now all comms will be aligned. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [INTERNAL] [FIXED] - fix changelog entries for dangerfiles and PR template Pull Request resolved: #35541 Test Plan: N/A Reviewed By: sammy-SC Differential Revision: D41686913 Pulled By: cortinico fbshipit-source-id: 2297b4a3209188bda4a609b60860de35c5e7e6df
1 parent 1d4396c commit e509007

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,16 @@
66

77
## Changelog
88

9-
<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
9+
<!-- Help reviewers and the release process by writing your own changelog entry.
10+
11+
Pick one each for the category and type tags:
12+
13+
[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
14+
15+
For more details, see:
1016
https://reactnative.dev/contributing/changelogs-in-pull-requests
1117
-->
1218

13-
[CATEGORY] [TYPE] - Message
14-
1519
## Test Plan
1620

1721
<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. -->

packages/react-native-bots/dangerfile.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ if (!includesTestPlan && !isFromPhabricator) {
5959

6060
// Regex looks for given categories, types, a file/framework/component, and a message - broken into 4 capture groups
6161
const changelogRegex =
62-
/\[\s?(ANDROID|GENERAL|IOS|JS|JAVASCRIPT|INTERNAL)\s?\]\s?\[\s?(ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY)\s?\]\s*?-?\s*?(.*)/gi;
62+
/\[\s?(ANDROID|GENERAL|IOS|INTERNAL)\s?\]\s?\[\s?(BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY)\s?\]\s*?-?\s*?(.*)/gi;
6363
const internalChangelogRegex = /\[\s?(INTERNAL)\s?\].*/gi;
6464
const includesChangelog =
6565
danger.github.pr.body &&

0 commit comments

Comments
 (0)