chore: fail prepare package for release if tag exists

Author: Riccardo Cipolleschi

scripts/bump-oss-version.js

@@ -21,6 +21,7 @@ const request = require('request');
 const {getBranchName, exitIfNotOnGit} = require('./scm-utils');
 
 const {parseVersion, isReleaseBranch} = require('./version-utils');
+const {failIfTagExists} = require('./release-utils');
 
 let argv = yargs
   .option('r', {
@@ -75,6 +76,7 @@ async function main() {
   );
   const token = argv.token;
   const releaseVersion = argv.toVersion;
+  failIfTagExists(releaseVersion);
 
   const {pushed} = await inquirer.prompt({
     type: 'confirm',

scripts/prepare-package-for-release.js

@@ -21,6 +21,7 @@
 const {echo, exec, exit} = require('shelljs');
 const yargs = require('yargs');
 const {isReleaseBranch, parseVersion} = require('./version-utils');
+const {failIfTagExists} = require('./release-utils');
 
 const argv = yargs
   .option('r', {
@@ -49,6 +50,8 @@ const releaseVersion = argv.toVersion;
 const isLatest = argv.latest;
 const isDryRun = argv.dryRun;
 
+failIfTagExists(releaseVersion);
+
 if (branch && !isReleaseBranch(branch) && !isDryRun) {
   console.error(`This needs to be on a release branch. On branch: ${branch}`);
   exit(1);

scripts/release-utils.js

@@ -111,8 +111,27 @@ function generateiOSArtifacts(
   return tarballOutputPath;
 }
 
+function failIfTagExists(version) {
+  if (checkIfTagExists(releaseVersion)) {
+    echo(`Tag v${releaseVersion} already exists.`);
+    echo('You may want to rollback the last commit');
+    echo('git reset --hard HEAD~1');
+    exit(1);
+  }
+}
+
+function checkIfTagExists(version) {
+  const {code, stdout} = exec('git tag -l', {silent: true});
+  if (code !== 0) {
+    throw new Error('Failed to retrieve the list of tags');
+  }
+  const tags = new Set(stdout.split('\n'));
+  return tags.has(`v${version}`);
+}
+
 module.exports = {
   generateAndroidArtifacts,
   generateiOSArtifacts,
   publishAndroidArtifactsToMaven,
+  failIfTagExists,
 };