Add @Nullable annotations to ViewManager.measure() parameters (#57039)#57039
Closed
javache wants to merge 1 commit into
Closed
Add @Nullable annotations to ViewManager.measure() parameters (#57039)#57039javache wants to merge 1 commit into
javache wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107229856. |
…ok#57039) Summary: Adds `Nullable` annotations to the `localData`, `props`, and `state` parameters in `ViewManager.java`'s `measure()` method to match the nullable Kotlin types (`ReadableMap?`) from `MountingManager.kt`. Changelog: [Android][Changed] Corrected nullability of `ViewManager#measure` Differential Revision: D107229856
meta-codesync
Bot
changed the title
javache
force-pushed
the
export-D107229856
branch
from
557d084 to
819100e
Compare
Collaborator
|
This pull request was successfully merged by @javache in 63683f0 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds
Nullableannotations to thelocalData,props, andstateparameters inViewManager.java'smeasure()method to match the nullable Kotlin types (ReadableMap?) fromMountingManager.kt.Changelog: [Android][Changed] Corrected nullability of
ViewManager#measureDifferential Revision: D107229856