Unify bridge and bridgeless ReactMarker implementations (#57040)#57040
Open
javache wants to merge 1 commit into
Open
Unify bridge and bridgeless ReactMarker implementations (#57040)#57040javache wants to merge 1 commit into
javache wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Summary: The split between `logTaggedMarkerImpl` and `logTaggedMarkerBridgelessImpl` no longer earns its keep — bridgeless callers always pass the same instance key, and the bridge mode is on its way out. Collapse the two paths into a single hook so platform code only has to wire up one slot. `LogTaggedMarkerBridgeless` becomes a type alias for `LogTaggedMarker`. The free `logMarkerBridgeless` / `logTaggedMarkerBridgeless` functions and the `logTaggedMarkerBridgelessImpl` slot stay around as `[[deprecated]]` shims. Call-sites in `ReactInstance` switch to the unified `logMarker` / `logTaggedMarker`. On the Android side, `logPerfMarkerBridgeless` and the `logPerfMarkerWithInstanceKey` indirection go away — there's only one instance key now. Changelog: [General][Deprecated] - Deprecate `logMarkerBridgeless`, `logTaggedMarkerBridgeless`, and `logTaggedMarkerBridgelessImpl` in favor of the non-bridgeless variants Differential Revision: D88068665
meta-codesync
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The split between
logTaggedMarkerImplandlogTaggedMarkerBridgelessImplno longer earns its keep — bridgeless callers always pass the same instance key, and the bridge mode is on its way out. Collapse the two paths into a single hook so platform code only has to wire up one slot.LogTaggedMarkerBridgelessbecomes a type alias forLogTaggedMarker. The freelogMarkerBridgeless/logTaggedMarkerBridgelessfunctions and thelogTaggedMarkerBridgelessImplslot stay around as[[deprecated]]shims. Call-sites inReactInstanceswitch to the unifiedlogMarker/logTaggedMarker. On the Android side,logPerfMarkerBridgelessand thelogPerfMarkerWithInstanceKeyindirection go away — there's only one instance key now.Changelog:
[General][Deprecated] - Deprecate
logMarkerBridgeless,logTaggedMarkerBridgeless, andlogTaggedMarkerBridgelessImplin favor of the non-bridgeless variantsDifferential Revision: D88068665