Skip to content

IntegrationWithExsistingApps Android Update #11687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saiprasad1996 wants to merge 4 commits into from
Closed

IntegrationWithExsistingApps Android Update #11687

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b04881
IntegrationWithExsistingApps Android Update
saiprasad1996 Dec 31, 2016
f23e5ff
Update IntegrationWithExistingApps.md
ericvicenti Jan 3, 2017
81acf29
Update IntegrationWithExistingApps.md
ericvicenti Jan 3, 2017
a2c4421
Update IntegrationWithExistingApps.md
ericvicenti Jan 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update IntegrationWithExistingApps.md
  • Loading branch information
@ericvicenti
ericvicenti authored Jan 3, 2017
commit f23e5ff5b835ce6b5ce996378d60fe8028241fc0
39 changes: 20 additions & 19 deletions docs/IntegrationWithExistingApps.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,7 @@ Next, we need to pass some activity lifecycle callbacks down to the `ReactInstan
protected void onPause() {
super.onPause();

if (mReactInstanceManager != null) {
if (mReactInstanceManager != null) {###
mReactInstanceManager.onHostPause(this);
}
}
Expand Down Expand Up @@ -726,35 +726,36 @@ public boolean onKeyUp(int keyCode, KeyEvent event) {
}
```

That's it, your activity is ready to run some JavaScript code.
Now your activity is ready to run some JavaScript code.

### Configure permissions for development error overlay

> If your app is targeting the Android `api level 23` or greater, make sure you have, for the development build, the `overlay permission` enabled. You can check it with `Settings.canDrawOverlays(this);`. This is required because, if your app produces an error in the react native component, the error view is displayed above all the other windows. Due to the new permissions system, introduced in the api level 23, the user needs to approve it. This can be acheived by adding the following code to the Activity file in the onCreate() method. OVERLA_PERMISSION_REQ_CODE is a field of the class which would be responsible for passing the result back to the Activity.
If your app is targeting the Android `API level 23` or greater, make sure you have the `overlay` permission enabled for the development build. You can check it with `Settings.canDrawOverlays(this);`. This is required in dev builds because react native development errors must be displayed above all the other windows. Due to the new permissions system introduced in the API level 23, the user needs to approve it. This can be acheived by adding the following code to the Activity file in the onCreate() method. OVERLAY_PERMISSION_REQ_CODE is a field of the class which would be responsible for passing the result back to the Activity.

```java
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
if (!Settings.canDrawOverlays(this)) {
Intent intent = new Intent(Settings.ACTION_MANAGE_OVERLAY_PERMISSION,
Uri.parse("package:" + getPackageName()));
startActivityForResult(intent, OVERLAY_PERMISSION_REQ_CODE);
}
}
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
if (!Settings.canDrawOverlays(this)) {
Intent intent = new Intent(Settings.ACTION_MANAGE_OVERLAY_PERMISSION,
Uri.parse("package:" + getPackageName()));
startActivityForResult(intent, OVERLAY_PERMISSION_REQ_CODE);
}
}
```
> Finally onActivityResult() method (as shown in the code below) has to be overridden to handle the permission Accepted or Denied cases for consistent UX.

```java

@Override
protected void onActivityResult(int requestCode, int resultCode, Intent data) {
if (requestCode == OVERLAY_PERMISSION_REQ_CODE) {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
if (!Settings.canDrawOverlays(this)) {
// SYSTEM_ALERT_WINDOW permission not granted...
}
@Override
protected void onActivityResult(int requestCode, int resultCode, Intent data) {
if (requestCode == OVERLAY_PERMISSION_REQ_CODE) {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
if (!Settings.canDrawOverlays(this)) {
// SYSTEM_ALERT_WINDOW permission not granted...
}
}
}

}
```

## Run your app

To run your app, you need to first start the development server. To do this, simply run the following command in your root folder:
Expand Down