Skip to content

Breaking: Remove incorrect hwb() syntax support from normalize-color #48912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NickGerleman wants to merge 6 commits into from
Closed

Breaking: Remove incorrect hwb() syntax support from normalize-color #48912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e1c1941
Add CSSDelimeter::OptionalWhitespace and CSSDelimeter::CommaOrWhitesp…
NickGerleman Jan 24, 2025
1c335c8
More spec compliant rgb function parsing (#48839)
NickGerleman Jan 24, 2025
7e4e80c
Do not consume delimeter when not consuming component value (#48841)
NickGerleman Jan 24, 2025
1a55d1e
Remove redundant check in CSSRatio (#48842)
NickGerleman Jan 24, 2025
dd98b45
Support parsing hsl() and hsla() functions (#48843)
NickGerleman Jan 24, 2025
83ff1ad
Breaking: Remove incorrect hwb() syntax support from normalize-color
NickGerleman Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/normalize-color/__tests__/normalizeColor-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,14 +127,15 @@ it('handles hsla properly', () => {
});

it('handles hwb properly', () => {
expect(normalizeColor('hwb(0, 0%, 100%)')).toBe(0x000000ff);
expect(normalizeColor('hwb(0, 100%, 0%)')).toBe(0xffffffff);
expect(normalizeColor('hwb(0, 0%, 0%)')).toBe(0xff0000ff);
expect(normalizeColor('hwb(70, 50%, 0%)')).toBe(0xeaff80ff);
expect(normalizeColor('hwb(0, 50%, 50%)')).toBe(0x808080ff);
expect(normalizeColor('hwb(360, 100%, 100%)')).toBe(0x808080ff);
expect(normalizeColor('hwb(0 0% 100%)')).toBe(0x000000ff);
expect(normalizeColor('hwb(0 100% 0%)')).toBe(0xffffffff);
expect(normalizeColor('hwb(0 0% 0%)')).toBe(0xff0000ff);
expect(normalizeColor('hwb(70 50% 0%)')).toBe(0xeaff80ff);
expect(normalizeColor('hwb(0 50% 50%)')).toBe(0x808080ff);
expect(normalizeColor('hwb(360 100% 100%)')).toBe(0x808080ff);
expect(normalizeColor('hwb(0 0% 0%)')).toBe(0xff0000ff);
expect(normalizeColor('hwb(70 50% 0%)')).toBe(0xeaff80ff);
expect(normalizeColor('hwb(0, 0%, 100%)')).toBe(null);
});

it('handles named colors properly', () => {
Expand Down
6 changes: 5 additions & 1 deletion packages/normalize-color/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,10 @@ function call(...args) {
return '\\(\\s*(' + args.join(')\\s*,?\\s*(') + ')\\s*\\)';
}

function callModern(...args) {
return '\\(\\s*(' + args.join(')\\s*(') + ')\\s*\\)';
}

function callWithSlashSeparator(...args) {
return (
'\\(\\s*(' +
Expand Down Expand Up @@ -251,7 +255,7 @@ function getMatchers() {
callWithSlashSeparator(NUMBER, PERCENTAGE, PERCENTAGE, NUMBER) +
')',
),
hwb: new RegExp('hwb' + call(NUMBER, PERCENTAGE, PERCENTAGE)),
hwb: new RegExp('hwb' + callModern(NUMBER, PERCENTAGE, PERCENTAGE)),
hex3: /^#([0-9a-fA-F]{1})([0-9a-fA-F]{1})([0-9a-fA-F]{1})$/,
hex4: /^#([0-9a-fA-F]{1})([0-9a-fA-F]{1})([0-9a-fA-F]{1})([0-9a-fA-F]{1})$/,
hex6: /^#([0-9a-fA-F]{6})$/,
Expand Down
Loading
Loading