Add support for Gradle Configuration caching #49484
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is the last diff to add support for Gradle Configuration caching. The last missing part here was the execution of the `config` command during Gradle configuration time. Using Java processes API is not supported as the correct way to do external commands that are CC-friendly is through the `.providers.exec` API which I'm using here. Closes facebook#45154 Changelog: [Android] [Added] - Add support for Gradle Configuration caching Differential Revision: D69753889
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69753889 |
This was referenced Feb 17, 2025
Contributor
|
This pull request has been merged in e41887e. |
Collaborator
|
This pull request was successfully merged by @cortinico in e41887e When will my fix make it into a release? | How to file a pick request? |
gabrieldonadel
pushed a commit
to gabrieldonadel/react-native
that referenced
this pull request
Aug 12, 2025
Summary: Pull Request resolved: facebook#49484 This is the last diff to add support for Gradle Configuration caching. The last missing part here was the execution of the `config` command during Gradle configuration time. Using Java processes API is not supported as the correct way to do external commands that are CC-friendly is through the `.providers.exec` API which I'm using here. Closes facebook#45154 Changelog: [Android] [Added] - Add support for Gradle Configuration caching Reviewed By: cipolleschi Differential Revision: D69753889 fbshipit-source-id: af1e844b38444659a908abce4029d43ad899c03d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is the last diff to add support for Gradle Configuration caching.
The last missing part here was the execution of the
configcommand during Gradle configuration time.Using Java processes API is not supported as the correct way to do external commands that are CC-friendly
is through the
.providers.execAPI which I'm using here.Closes #45154
Changelog:
[Android] [Added] - Add support for Gradle Configuration caching
Differential Revision: D69753889