Skip to content

Fix flaky TaskDispatchThreadTest/RunAsyncWithDelay timing test #57041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cortinico wants to merge 1 commit into from
+14 −5
Closed

Fix flaky TaskDispatchThreadTest/RunAsyncWithDelay timing test #57041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions packages/react-native/ReactCxxPlatform/react/threading/tests/TaskDispatchThreadTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#include <react/threading/TaskDispatchThread.h>
#include <atomic>
#include <chrono>
#include <future>
#include <thread>

namespace facebook::react {
Expand Down Expand Up @@ -52,11 +53,19 @@ TEST_F(TaskDispatchThreadTest, RunSyncExecutesTask) {
// Test: runAsync with delay
TEST_F(TaskDispatchThreadTest, RunAsyncWithDelay) {
std::atomic<int> counter{0};
dispatcher->runAsync([&] { counter++; }, std::chrono::milliseconds(100));
std::this_thread::sleep_for(std::chrono::milliseconds(50));
EXPECT_EQ(counter.load(), 0); // Not yet executed
std::this_thread::sleep_for(std::chrono::milliseconds(70));
EXPECT_EQ(counter.load(), 1); // Should be executed now
std::promise<void> taskDone;
auto future = taskDone.get_future();
dispatcher->runAsync(
[&] {
counter++;
taskDone.set_value();
},
std::chrono::milliseconds(200));
std::this_thread::sleep_for(std::chrono::milliseconds(20));
EXPECT_EQ(counter.load(), 0); // 20ms << 200ms, not yet executed
ASSERT_EQ(
future.wait_for(std::chrono::seconds(5)), std::future_status::ready);
EXPECT_EQ(counter.load(), 1); // Task completed
}

// Test: Multiple delayed tasks execute in order
Expand Down
Loading