Skip to content

Commit 18f04e1

Browse files
committed
Remove object-assign polyfill
1 parent 6606511 commit 18f04e1

File tree

10 files changed

+40
-107
lines changed

10 files changed

+40
-107
lines changed

packages/react-art/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@
1919
"homepage": "https://facebook.github.io/react/",
2020
"dependencies": {
2121
"fbjs": "^0.8.9",
22-
"loose-envify": "^1.1.0",
23-
"object-assign": "^4.1.0"
22+
"loose-envify": "^1.1.0"
2423
},
2524
"peerDependencies": {
2625
"react": "^16.0.0-alpha.13"

packages/react-dom/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
"dependencies": {
1616
"fbjs": "^0.8.9",
1717
"loose-envify": "^1.1.0",
18-
"object-assign": "^4.1.0",
1918
"prop-types": "^15.5.6"
2019
},
2120
"peerDependencies": {

packages/react-noop-renderer/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
"repository": "facebook/react",
88
"license": "BSD-3-Clause",
99
"dependencies": {
10-
"fbjs": "^0.8.9",
11-
"object-assign": "^4.1.0"
10+
"fbjs": "^0.8.9"
1211
},
1312
"files": [
1413
"LICENSE",

packages/react-test-renderer/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@
1515
},
1616
"homepage": "https://facebook.github.io/react/",
1717
"dependencies": {
18-
"fbjs": "^0.8.9",
19-
"object-assign": "^4.1.0"
18+
"fbjs": "^0.8.9"
2019
},
2120
"peerDependencies": {
2221
"react": "^16.0.0-alpha.13"

packages/react/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
"dependencies": {
2525
"fbjs": "^0.8.9",
2626
"loose-envify": "^1.1.0",
27-
"object-assign": "^4.1.0",
2827
"prop-types": "^15.5.6"
2928
},
3029
"browserify": {

scripts/babel/transform-object-assign-require.js

Lines changed: 0 additions & 51 deletions
This file was deleted.

scripts/jest/preprocessor.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,7 @@ var babelOptions = {
4343
[
4444
babelPluginModules,
4545
{
46-
map: Object.assign({}, moduleMap, {
47-
'object-assign': 'object-assign',
48-
}),
46+
map: moduleMap,
4947
},
5048
],
5149
// Keep stacks detailed in tests.

scripts/rollup/build.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ const replace = require('rollup-plugin-replace');
99
const chalk = require('chalk');
1010
const escapeStringRegexp = require('escape-string-regexp');
1111
const join = require('path').join;
12-
const resolve = require('path').resolve;
1312
const fs = require('fs');
1413
const rimraf = require('rimraf');
1514
const argv = require('minimist')(process.argv.slice(2));
@@ -124,8 +123,6 @@ function updateBabelConfig(babelOpts, bundleType) {
124123
case NODE_PROD:
125124
return Object.assign({}, babelOpts, {
126125
plugins: babelOpts.plugins.concat([
127-
// Use object-assign polyfill in open source
128-
resolve('./scripts/babel/transform-object-assign-require'),
129126
// Replace __DEV__ with process.env.NODE_ENV and minify invariant messages
130127
require('../error-codes/dev-expression-with-codes'),
131128
]),

scripts/rollup/modules.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -88,14 +88,10 @@ function createModuleMap(paths, extractErrors, bundleType) {
8888
}
8989

9090
function getNodeModules(bundleType) {
91-
// rather than adding the rollup node resolve plugin,
92-
// we can instead deal with the only node module that is used
93-
// for UMD bundles - object-assign
9491
switch (bundleType) {
9592
case UMD_DEV:
9693
case UMD_PROD:
9794
return {
98-
'object-assign': resolve('./node_modules/object-assign/index.js'),
9995
// include the ART package modules directly by aliasing them from node_modules
10096
'art/modes/current': resolve('./node_modules/art/modes/current.js'),
10197
'art/modes/fast-noSideEffects': resolve(
@@ -156,8 +152,6 @@ function getExternalModules(externals, bundleType, isRenderer) {
156152
case RN_DEV:
157153
case RN_PROD:
158154
fbjsModules.forEach(module => externalModules.push(module));
159-
externalModules.push('object-assign');
160-
161155
if (isRenderer) {
162156
externalModules.push('react');
163157
}

scripts/rollup/results.json

Lines changed: 36 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
11
{
22
"bundleSizes": {
33
"react.development.js (UMD_DEV)": {
4-
"size": 65928,
5-
"gzip": 16792
4+
"size": 63860,
5+
"gzip": 16063
66
},
77
"react.production.min.js (UMD_PROD)": {
8-
"size": 6738,
9-
"gzip": 2759
8+
"size": 5854,
9+
"gzip": 2398
1010
},
1111
"react.development.js (NODE_DEV)": {
12-
"size": 56228,
13-
"gzip": 14438
12+
"size": 56177,
13+
"gzip": 14420
1414
},
1515
"react.production.min.js (NODE_PROD)": {
16-
"size": 5598,
17-
"gzip": 2334
16+
"size": 5605,
17+
"gzip": 2327
1818
},
1919
"React-dev.js (FB_DEV)": {
2020
"size": 53485,
@@ -25,20 +25,20 @@
2525
"gzip": 6705
2626
},
2727
"react-dom.development.js (UMD_DEV)": {
28-
"size": 630876,
29-
"gzip": 143999
28+
"size": 628906,
29+
"gzip": 143288
3030
},
3131
"react-dom.production.min.js (UMD_PROD)": {
32-
"size": 127001,
33-
"gzip": 40233
32+
"size": 126236,
33+
"gzip": 39919
3434
},
3535
"react-dom.development.js (NODE_DEV)": {
36-
"size": 590270,
37-
"gzip": 134359
36+
"size": 590326,
37+
"gzip": 134354
3838
},
3939
"react-dom.production.min.js (NODE_PROD)": {
40-
"size": 123917,
41-
"gzip": 39159
40+
"size": 124043,
41+
"gzip": 39170
4242
},
4343
"ReactDOMFiber-dev.js (FB_DEV)": {
4444
"size": 589473,
@@ -65,20 +65,20 @@
6565
"gzip": 81957
6666
},
6767
"react-dom-server.development.js (UMD_DEV)": {
68-
"size": 121172,
69-
"gzip": 30762
68+
"size": 119150,
69+
"gzip": 30045
7070
},
7171
"react-dom-server.production.min.js (UMD_PROD)": {
72-
"size": 20365,
73-
"gzip": 7841
72+
"size": 19541,
73+
"gzip": 7501
7474
},
7575
"react-dom-server.development.js (NODE_DEV)": {
76-
"size": 90322,
77-
"gzip": 23339
76+
"size": 90286,
77+
"gzip": 23330
7878
},
7979
"react-dom-server.production.min.js (NODE_PROD)": {
80-
"size": 18871,
81-
"gzip": 7306
80+
"size": 18938,
81+
"gzip": 7302
8282
},
8383
"ReactDOMServerStream-dev.js (FB_DEV)": {
8484
"size": 264750,
@@ -189,12 +189,12 @@
189189
"gzip": 13644
190190
},
191191
"react-dom-node-stream.development.js (NODE_DEV)": {
192-
"size": 92016,
193-
"gzip": 23840
192+
"size": 91980,
193+
"gzip": 23825
194194
},
195195
"react-dom-node-stream.production.min.js (NODE_PROD)": {
196-
"size": 19808,
197-
"gzip": 7646
196+
"size": 19875,
197+
"gzip": 7641
198198
},
199199
"ReactDOMNodeStream-dev.js (FB_DEV)": {
200200
"size": 264918,
@@ -205,20 +205,20 @@
205205
"gzip": 50956
206206
},
207207
"react-dom-unstable-native-dependencies.development.js (UMD_DEV)": {
208-
"size": 87163,
209-
"gzip": 21689
208+
"size": 85091,
209+
"gzip": 20954
210210
},
211211
"react-dom-unstable-native-dependencies.production.min.js (UMD_PROD)": {
212-
"size": 18899,
213-
"gzip": 6159
212+
"size": 18013,
213+
"gzip": 5783
214214
},
215215
"react-dom-unstable-native-dependencies.development.js (NODE_DEV)": {
216-
"size": 80583,
217-
"gzip": 19737
216+
"size": 80533,
217+
"gzip": 19717
218218
},
219219
"react-dom-unstable-native-dependencies.production.min.js (NODE_PROD)": {
220-
"size": 17154,
221-
"gzip": 5513
220+
"size": 17160,
221+
"gzip": 5515
222222
},
223223
"ReactDOMUnstableNativeDependencies-dev.js (FB_DEV)": {
224224
"size": 79722,

0 commit comments

Comments
 (0)