Commit 355d677
committed
Remove method name prefix from warnings and errors (#28432)
This pattern is a petpeeve of mine. I don't consider this best practice
and so most don't have these prefixes. Very inconsistent.
At best this is useless and noisey that you have to parse because the
information is also in the stack trace.
At worse these are misleading because they're highlighting something
internal (like validateDOMNesting) which even suggests an internal bug.
Even the ones public to React aren't necessarily what you called because
you might be calling a wrapper around it.
That would be properly reflected in a stack trace - which can also
properly ignore list so that the first stack you see is your callsite,
Which might be like `render()` in react-testing-library rather than
`createRoot()` for example.
DiffTrain build for commit d579e77.1 parent 2b0bca0 commit 355d677
File tree
13 files changed
+96
-131
lines changed- compiled-rn/facebook-fbsource/xplat/js
- RKJSModules/vendor
- react-test-renderer/cjs
- react/cjs
- react-native-github/Libraries/Renderer
- implementations
13 files changed
+96
-131
lines changedLines changed: 15 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
10966 | 10966 | | |
10967 | 10967 | | |
10968 | 10968 | | |
10969 | | - | |
| 10969 | + | |
10970 | 10970 | | |
10971 | 10971 | | |
10972 | 10972 | | |
10973 | | - | |
| 10973 | + | |
10974 | 10974 | | |
10975 | | - | |
| 10975 | + | |
10976 | 10976 | | |
10977 | 10977 | | |
10978 | 10978 | | |
10979 | 10979 | | |
10980 | 10980 | | |
10981 | | - | |
| 10981 | + | |
10982 | 10982 | | |
10983 | | - | |
10984 | 10983 | | |
10985 | 10984 | | |
10986 | 10985 | | |
| |||
11043 | 11042 | | |
11044 | 11043 | | |
11045 | 11044 | | |
11046 | | - | |
| 11045 | + | |
11047 | 11046 | | |
11048 | 11047 | | |
11049 | 11048 | | |
| |||
11065 | 11064 | | |
11066 | 11065 | | |
11067 | 11066 | | |
11068 | | - | |
| 11067 | + | |
11069 | 11068 | | |
11070 | 11069 | | |
11071 | 11070 | | |
| |||
11087 | 11086 | | |
11088 | 11087 | | |
11089 | 11088 | | |
11090 | | - | |
| 11089 | + | |
11091 | 11090 | | |
11092 | 11091 | | |
11093 | 11092 | | |
| |||
11152 | 11151 | | |
11153 | 11152 | | |
11154 | 11153 | | |
11155 | | - | |
| 11154 | + | |
11156 | 11155 | | |
11157 | 11156 | | |
11158 | 11157 | | |
11159 | 11158 | | |
11160 | 11159 | | |
11161 | | - | |
| 11160 | + | |
11162 | 11161 | | |
11163 | 11162 | | |
11164 | 11163 | | |
| |||
11293 | 11292 | | |
11294 | 11293 | | |
11295 | 11294 | | |
11296 | | - | |
| 11295 | + | |
11297 | 11296 | | |
11298 | | - | |
11299 | 11297 | | |
11300 | 11298 | | |
11301 | 11299 | | |
| |||
13963 | 13961 | | |
13964 | 13962 | | |
13965 | 13963 | | |
13966 | | - | |
| 13964 | + | |
| 13965 | + | |
13967 | 13966 | | |
13968 | 13967 | | |
13969 | 13968 | | |
| |||
25728 | 25727 | | |
25729 | 25728 | | |
25730 | 25729 | | |
25731 | | - | |
| 25730 | + | |
25732 | 25731 | | |
25733 | 25732 | | |
25734 | 25733 | | |
| |||
25825 | 25824 | | |
25826 | 25825 | | |
25827 | 25826 | | |
25828 | | - | |
| 25827 | + | |
25829 | 25828 | | |
25830 | 25829 | | |
25831 | 25830 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9171 | 9171 | | |
9172 | 9172 | | |
9173 | 9173 | | |
9174 | | - | |
| 9174 | + | |
9175 | 9175 | | |
9176 | 9176 | | |
9177 | 9177 | | |
| |||
9202 | 9202 | | |
9203 | 9203 | | |
9204 | 9204 | | |
9205 | | - | |
| 9205 | + | |
9206 | 9206 | | |
9207 | 9207 | | |
9208 | 9208 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9599 | 9599 | | |
9600 | 9600 | | |
9601 | 9601 | | |
9602 | | - | |
| 9602 | + | |
9603 | 9603 | | |
9604 | 9604 | | |
9605 | 9605 | | |
| |||
9630 | 9630 | | |
9631 | 9631 | | |
9632 | 9632 | | |
9633 | | - | |
| 9633 | + | |
9634 | 9634 | | |
9635 | 9635 | | |
9636 | 9636 | | |
| |||
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
383 | 383 | | |
384 | 384 | | |
385 | 385 | | |
386 | | - | |
| 386 | + | |
387 | 387 | | |
388 | 388 | | |
389 | 389 | | |
| |||
1885 | 1885 | | |
1886 | 1886 | | |
1887 | 1887 | | |
1888 | | - | |
| 1888 | + | |
1889 | 1889 | | |
1890 | 1890 | | |
1891 | 1891 | | |
| |||
2806 | 2806 | | |
2807 | 2807 | | |
2808 | 2808 | | |
2809 | | - | |
| 2809 | + | |
2810 | 2810 | | |
2811 | 2811 | | |
2812 | 2812 | | |
| |||
2827 | 2827 | | |
2828 | 2828 | | |
2829 | 2829 | | |
2830 | | - | |
| 2830 | + | |
2831 | 2831 | | |
2832 | 2832 | | |
2833 | 2833 | | |
| |||
Lines changed: 4 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| |||
422 | 422 | | |
423 | 423 | | |
424 | 424 | | |
425 | | - | |
426 | | - | |
427 | | - | |
| 425 | + | |
428 | 426 | | |
429 | 427 | | |
430 | 428 | | |
| |||
600 | 598 | | |
601 | 599 | | |
602 | 600 | | |
603 | | - | |
| 601 | + | |
Lines changed: 4 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
| 67 | + | |
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| |||
389 | 389 | | |
390 | 390 | | |
391 | 391 | | |
392 | | - | |
393 | | - | |
394 | | - | |
| 392 | + | |
395 | 393 | | |
396 | 394 | | |
397 | 395 | | |
| |||
596 | 594 | | |
597 | 595 | | |
598 | 596 | | |
599 | | - | |
| 597 | + | |
600 | 598 | | |
601 | 599 | | |
602 | 600 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
0 commit comments