Skip to content

Commit 612e740

Browse files
committed
Clean up Scheduler forks
1 parent d857f9e commit 612e740

21 files changed

+45
-1508
lines changed

.codesandbox/ci.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"packages": ["packages/react", "packages/react-dom", "packages/scheduler"],
3-
"buildCommand": "build --type=NODE react/index,react-dom/index,react-dom/server,react-dom/test-utils,scheduler/index,scheduler/unstable_no_dom,scheduler/tracing,react/jsx-runtime,react/jsx-dev-runtime",
3+
"buildCommand": "build --type=NODE react/index,react-dom/index,react-dom/server,react-dom/test-utils,scheduler/index,scheduler/tracing,react/jsx-runtime,react/jsx-dev-runtime",
44
"publishDirectory": {
55
"react": "build/node_modules/react",
66
"react-dom": "build/node_modules/react-dom",

packages/react-dom/src/__tests__/ReactTestUtilsActUnmockedScheduler-test.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,7 @@ function unmount(dom) {
3333

3434
beforeEach(() => {
3535
jest.resetModules();
36-
jest.mock('scheduler', () =>
37-
require.requireActual('scheduler/unstable_no_dom'),
38-
);
36+
jest.unmock('scheduler');
3937
yields = [];
4038
React = require('react');
4139
ReactDOM = require('react-dom');

packages/react-dom/src/__tests__/ReactUnmockedSchedulerWarning-test.internal.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ function App() {
1717

1818
beforeEach(() => {
1919
jest.resetModules();
20-
jest.mock('scheduler', () => require('scheduler/unstable_no_dom'));
20+
jest.unmock('scheduler');
2121
React = require('react');
2222
ReactDOM = require('react-dom');
2323
ReactFeatureFlags = require('shared/ReactFeatureFlags');

packages/react-dom/src/__tests__/ReactUnmockedSchedulerWarning-test.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@ function App() {
1616

1717
beforeEach(() => {
1818
jest.resetModules();
19-
jest.mock('scheduler', () =>
20-
require.requireActual('scheduler/unstable_no_dom'),
21-
);
19+
jest.unmock('scheduler');
2220
React = require('react');
2321
ReactDOM = require('react-dom');
2422
});

packages/scheduler/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@
77

88
'use strict';
99

10-
export * from './src/forks/SchedulerDOM';
10+
export * from './src/forks/Scheduler';

packages/scheduler/npm/index.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
'use strict';
22

3-
if (typeof window === 'undefined' || typeof MessageChannel !== 'function') {
4-
module.exports = require('./unstable_no_dom');
5-
} else if (process.env.NODE_ENV === 'production') {
3+
if (process.env.NODE_ENV === 'production') {
64
module.exports = require('./cjs/scheduler.production.min.js');
75
} else {
86
module.exports = require('./cjs/scheduler.development.js');

packages/scheduler/npm/unstable_no_dom.js

Lines changed: 0 additions & 7 deletions
This file was deleted.

packages/scheduler/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
"tracing.js",
2929
"tracing-profiling.js",
3030
"unstable_mock.js",
31-
"unstable_no_dom.js",
3231
"unstable_post_task.js",
3332
"cjs/",
3433
"umd/"

packages/scheduler/src/__tests__/SchedulerDOM-test.js renamed to packages/scheduler/src/__tests__/Scheduler-test.js

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,7 @@ let NormalPriority;
3232
describe('SchedulerBrowser', () => {
3333
beforeEach(() => {
3434
jest.resetModules();
35-
36-
// Un-mock scheduler
37-
jest.mock('scheduler', () => require.requireActual('scheduler'));
35+
jest.unmock('scheduler');
3836

3937
runtime = installMockBrowserRuntime();
4038
performance = global.performance;
@@ -71,11 +69,6 @@ describe('SchedulerBrowser', () => {
7169
const window = {};
7270
global.window = window;
7371

74-
// TODO: Scheduler no longer requires these methods to be polyfilled. But
75-
// maybe we want to continue warning if they don't exist, to preserve the
76-
// option to rely on it in the future?
77-
window.requestAnimationFrame = window.cancelAnimationFrame = () => {};
78-
7972
window.setTimeout = (cb, delay) => {
8073
const id = timerIDCounter++;
8174
log(`Set Timer`);

packages/scheduler/src/__tests__/SchedulerPostTask-test.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ let IdlePriority;
3030
describe('SchedulerPostTask', () => {
3131
beforeEach(() => {
3232
jest.resetModules();
33-
34-
// Un-mock scheduler
3533
jest.mock('scheduler', () =>
3634
require.requireActual('scheduler/unstable_post_task'),
3735
);

0 commit comments

Comments
 (0)