Skip to content

Commit 6b19def

Browse files
committed
Fix logic around attribute seralization (#26526)
There was a bug in the attribute seralization for stylesheet resources injected by the Fizz runtime. For boolean properties the attribute value was set to an empty string but later immediately set to a string coerced value. This PR fixes that bug and refactors the code paths to be clearer DiffTrain build for commit 4a1cc2d.
1 parent 329d083 commit 6b19def

File tree

13 files changed

+19
-19
lines changed

13 files changed

+19
-19
lines changed

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23882,7 +23882,7 @@ function createFiberRoot(
2388223882
return root;
2388323883
}
2388423884

23885-
var ReactVersion = "18.3.0-next-b14f8da15-20230403";
23885+
var ReactVersion = "18.3.0-next-4a1cc2ddd-20230403";
2388623886

2388723887
// Might add PROFILE later.
2388823888

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8683,7 +8683,7 @@ var devToolsConfig$jscomp$inline_1028 = {
86838683
throw Error("TestRenderer does not support findFiberByHostInstance()");
86848684
},
86858685
bundleType: 0,
8686-
version: "18.3.0-next-b14f8da15-20230403",
8686+
version: "18.3.0-next-4a1cc2ddd-20230403",
86878687
rendererPackageName: "react-test-renderer"
86888688
};
86898689
var internals$jscomp$inline_1220 = {
@@ -8714,7 +8714,7 @@ var internals$jscomp$inline_1220 = {
87148714
scheduleRoot: null,
87158715
setRefreshHandler: null,
87168716
getCurrentFiber: null,
8717-
reconcilerVersion: "18.3.0-next-b14f8da15-20230403"
8717+
reconcilerVersion: "18.3.0-next-4a1cc2ddd-20230403"
87188718
};
87198719
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
87208720
var hook$jscomp$inline_1221 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9108,7 +9108,7 @@ var devToolsConfig$jscomp$inline_1070 = {
91089108
throw Error("TestRenderer does not support findFiberByHostInstance()");
91099109
},
91109110
bundleType: 0,
9111-
version: "18.3.0-next-b14f8da15-20230403",
9111+
version: "18.3.0-next-4a1cc2ddd-20230403",
91129112
rendererPackageName: "react-test-renderer"
91139113
};
91149114
var internals$jscomp$inline_1261 = {
@@ -9139,7 +9139,7 @@ var internals$jscomp$inline_1261 = {
91399139
scheduleRoot: null,
91409140
setRefreshHandler: null,
91419141
getCurrentFiber: null,
9142-
reconcilerVersion: "18.3.0-next-b14f8da15-20230403"
9142+
reconcilerVersion: "18.3.0-next-4a1cc2ddd-20230403"
91439143
};
91449144
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
91459145
var hook$jscomp$inline_1262 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-next-b14f8da15-20230403";
30+
var ReactVersion = "18.3.0-next-4a1cc2ddd-20230403";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,4 +639,4 @@ exports.useSyncExternalStore = function (
639639
);
640640
};
641641
exports.useTransition = useTransition;
642-
exports.version = "18.3.0-next-b14f8da15-20230403";
642+
exports.version = "18.3.0-next-4a1cc2ddd-20230403";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,7 +642,7 @@ exports.useSyncExternalStore = function (
642642
);
643643
};
644644
exports.useTransition = useTransition;
645-
exports.version = "18.3.0-next-b14f8da15-20230403";
645+
exports.version = "18.3.0-next-4a1cc2ddd-20230403";
646646

647647
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
648648
if (
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
b14f8da15598cdc2253529a905421ac795d68ab1
1+
4a1cc2ddd035f5c269e82ab6f7686e2e60d3b3ea

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27158,7 +27158,7 @@ function createFiberRoot(
2715827158
return root;
2715927159
}
2716027160

27161-
var ReactVersion = "18.3.0-next-b14f8da15-20230403";
27161+
var ReactVersion = "18.3.0-next-4a1cc2ddd-20230403";
2716227162

2716327163
function createPortal$1(
2716427164
children,

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9554,7 +9554,7 @@ var roots = new Map(),
95549554
devToolsConfig$jscomp$inline_1048 = {
95559555
findFiberByHostInstance: getInstanceFromNode,
95569556
bundleType: 0,
9557-
version: "18.3.0-next-b14f8da15-20230403",
9557+
version: "18.3.0-next-4a1cc2ddd-20230403",
95589558
rendererPackageName: "react-native-renderer",
95599559
rendererConfig: {
95609560
getInspectorDataForViewTag: function () {
@@ -9596,7 +9596,7 @@ var internals$jscomp$inline_1293 = {
95969596
scheduleRoot: null,
95979597
setRefreshHandler: null,
95989598
getCurrentFiber: null,
9599-
reconcilerVersion: "18.3.0-next-b14f8da15-20230403"
9599+
reconcilerVersion: "18.3.0-next-4a1cc2ddd-20230403"
96009600
};
96019601
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
96029602
var hook$jscomp$inline_1294 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10262,7 +10262,7 @@ var roots = new Map(),
1026210262
devToolsConfig$jscomp$inline_1126 = {
1026310263
findFiberByHostInstance: getInstanceFromNode,
1026410264
bundleType: 0,
10265-
version: "18.3.0-next-b14f8da15-20230403",
10265+
version: "18.3.0-next-4a1cc2ddd-20230403",
1026610266
rendererPackageName: "react-native-renderer",
1026710267
rendererConfig: {
1026810268
getInspectorDataForViewTag: function () {
@@ -10317,7 +10317,7 @@ var roots = new Map(),
1031710317
scheduleRoot: null,
1031810318
setRefreshHandler: null,
1031910319
getCurrentFiber: null,
10320-
reconcilerVersion: "18.3.0-next-b14f8da15-20230403"
10320+
reconcilerVersion: "18.3.0-next-4a1cc2ddd-20230403"
1032110321
});
1032210322
exports.createPortal = function (children, containerTag) {
1032310323
return createPortal$1(

0 commit comments

Comments
 (0)