Skip to content

Commit 6bc4167

Browse files
committed
Fiber HostConfig add getPublicInstance. This should be the identity fn everywhere except the test renderer
1 parent f200a6d commit 6bc4167

File tree

5 files changed

+18
-5
lines changed

5 files changed

+18
-5
lines changed

src/renderers/art/ReactARTFiber.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -460,6 +460,10 @@ const ARTRenderer = ReactFiberReconciler({
460460
// Noop
461461
},
462462

463+
getPublicInstance(instance) {
464+
return instance;
465+
},
466+
463467
insertBefore(parentInstance, child, beforeChild) {
464468
invariant(
465469
child !== beforeChild,

src/renderers/dom/fiber/ReactDOMFiber.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,10 @@ var DOMRenderer = ReactFiberReconciler({
123123
return getChildNamespace(parentNamespace, type);
124124
},
125125

126+
getPublicInstance(instance) {
127+
return instance;
128+
},
129+
126130
prepareForCommit() : void {
127131
eventsEnabled = ReactBrowserEventEmitter.isEnabled();
128132
ReactBrowserEventEmitter.setEnabled(false);

src/renderers/native/ReactNativeFiber.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,10 @@ const NativeRenderer = ReactFiberReconciler({
220220
return emptyObject;
221221
},
222222

223+
getPublicInstance(instance) {
224+
return instance;
225+
},
226+
223227
insertBefore(
224228
parentInstance : Instance | Container,
225229
child : Instance | TextInstance,

src/renderers/noop/ReactNoop.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,10 @@ var NoopRenderer = ReactFiberReconciler({
5454
return emptyObject;
5555
},
5656

57+
getPublicInstance(instance) {
58+
return instance;
59+
},
60+
5761
createInstance(type : string, props : Props) : Instance {
5862
const inst = {
5963
id: instanceCounter++,

src/renderers/shared/fiber/ReactFiberCommitWork.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ module.exports = function<T, P, I, TI, C, CX>(
4646
appendChild,
4747
insertBefore,
4848
removeChild,
49+
getPublicInstance,
4950
} = config;
5051

5152
const {
@@ -86,11 +87,7 @@ module.exports = function<T, P, I, TI, C, CX>(
8687
function attachRef(current : ?Fiber, finishedWork : Fiber, instance : any) {
8788
const ref = finishedWork.ref;
8889
if (ref && (!current || current.ref !== ref)) {
89-
if (typeof config.getPublicInstance === 'function') {
90-
ref(config.getPublicInstance(instance));
91-
} else {
92-
ref(instance);
93-
}
90+
ref(getPublicInstance(instance));
9491
}
9592
}
9693

0 commit comments

Comments
 (0)