Skip to content

Commit 45ba69d

Browse files
cdtwiggmeta-codesync[bot]
authored andcommitted
Relax numerical Jacobian threshold for PointTriangleSkinnedLocatorError (#1049)
Summary: Pull Request resolved: #1049 The double-precision numerical Jacobian check for PointTriangleSkinnedLocatorError_GradientsAndJacobians was failing with an error of 0.000632 against a threshold of 0.0005. This is expected finite-difference noise, so relax the double threshold from 5e-4 to 1e-3, which matches the default getNumThreshold() for double. Reviewed By: cstollmeta Differential Revision: D93494524 fbshipit-source-id: 74b64d175bf5d820f47e4fc9b3f02fc2d06256f7
1 parent 7eb1354 commit 45ba69d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

momentum/test/character_solver/error_functions_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -689,7 +689,7 @@ TYPED_TEST(Momentum_ErrorFunctionsTest, PointTriangleSkinnedLocatorError_Gradien
689689
ModelParametersT<T> parameters =
690690
0.25 * uniform<VectorX<T>>(transform.numAllModelParameters(), -1, 1);
691691
TEST_GRADIENT_AND_JACOBIAN(
692-
T, &errorFunction, parameters, character, Eps<T>(0.03, 5e-4), true, true);
692+
T, &errorFunction, parameters, character, Eps<T>(0.03, 1e-3), true, true);
693693
}
694694
}
695695
}

0 commit comments

Comments
 (0)