Fix modernize-return-braced-init-list code quality issues

Reviewed By: cstollmeta

Differential Revision: D89008061

fbshipit-source-id: 28a6d1e863d384298d5f0a4bba3af4646f9b2e7c

Author: jeongseok-meta

momentum/rasterizer/utility.h

@@ -131,7 +131,7 @@ inline Vector3f toEnokiVec(const Eigen::Vector3f& v) {
 }
 
 inline Matrix3f toEnokiMat(const Eigen::Matrix3f& m) {
-  return Matrix3f(m(0, 0), m(0, 1), m(0, 2), m(1, 0), m(1, 1), m(1, 2), m(2, 0), m(2, 1), m(2, 2));
+  return {m(0, 0), m(0, 1), m(0, 2), m(1, 0), m(1, 1), m(1, 2), m(2, 0), m(2, 1), m(2, 2)};
 }
 
 inline auto extractSingleElement(const Matrix3dP& mat, int index) {

momentum/test/character/character_utility_test.cpp

@@ -897,7 +897,7 @@ Character createTestCharacterWithConstrainedJoints() {
   }
   parameterTransform.transform.setFromTriplets(triplets.begin(), triplets.end());
 
-  return Character(skeleton, parameterTransform);
+  return {skeleton, parameterTransform};
 }
 
 // Test fixture for SkeletonStateToJointParametersRespectingTransform tests

pymomentum/geometry/momentum_geometry.cpp

@@ -145,7 +145,7 @@ momentum::Character loadConfigFromFile(
   const auto [parameterTransform, parameterLimits] =
       momentum::loadModelDefinition(filesystem::path(configPath), character.skeleton);
 
-  return momentum::Character(
+  return {
       character.skeleton,
       parameterTransform,
       parameterLimits,
@@ -158,7 +158,7 @@ momentum::Character loadConfigFromFile(
       character.faceExpressionBlendShape,
       character.name,
       character.inverseBindPose,
-      character.skinnedLocators);
+      character.skinnedLocators};
 }
 
 momentum::Character loadFBXCharacterFromBytes(
@@ -180,7 +180,7 @@ momentum::Character loadConfigFromBytes(
   const auto [parameterTransform, parameterLimits] =
       momentum::loadModelDefinition(toSpan<std::byte>(bytes), character.skeleton);
 
-  return momentum::Character(
+  return {
       character.skeleton,
       parameterTransform,
       parameterLimits,
@@ -193,7 +193,7 @@ momentum::Character loadConfigFromBytes(
       character.faceExpressionBlendShape,
       character.name,
       character.inverseBindPose,
-      character.skinnedLocators);
+      character.skinnedLocators};
 }
 
 momentum::Character loadLocatorsFromBytes(
@@ -377,7 +377,7 @@ momentum::Character replaceRestMesh(const momentum::Character& character, RowMat
   }
   newMesh.updateNormals();
 
-  return momentum::Character(
+  return {
       character.skeleton,
       character.parameterTransform,
       character.parameterLimits,
@@ -390,7 +390,7 @@ momentum::Character replaceRestMesh(const momentum::Character& character, RowMat
       character.faceExpressionBlendShape,
       character.name,
       character.inverseBindPose,
-      character.skinnedLocators);
+      character.skinnedLocators};
 }
 
 // Get a boolean vector for selected vertices from selected bones.