feat(finance): branch code option in bic()#1378
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1378 +/- ##
=======================================
Coverage 99.62% 99.63%
=======================================
Files 2163 2163
Lines 241264 241275 +11
Branches 1014 1018 +4
=======================================
+ Hits 240357 240392 +35
+ Misses 886 862 -24
Partials 21 21
|
Shinigami92
requested changes
Sep 18, 2022
ST-DDT
reviewed
Sep 18, 2022
Member
|
Tests dont pass |
ejcheng
commented
Sep 20, 2022
Member
ST-DDT
reviewed
Sep 20, 2022
Member
Author
|
Seems like |
c8dc7d2 to
820aca1
Compare
Member
Maybe report this to validatorjs for them to fix? |
Member
Author
|
ST-DDT
approved these changes
Sep 20, 2022
Shinigami92
approved these changes
Sep 22, 2022
wael-fadlallah
pushed a commit
to wael-fadlallah/faker
that referenced
this pull request
Oct 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1158