Skip to content

feat(finance): branch code option in bic()#1378

Merged
ST-DDT merged 12 commits intomainfrom
feat/branch_code_option
Sep 22, 2022
Merged

feat(finance): branch code option in bic()#1378
ST-DDT merged 12 commits intomainfrom
feat/branch_code_option

Conversation

@ejcheng
Copy link
Copy Markdown
Member

@ejcheng ejcheng commented Sep 18, 2022

closes #1158

@ejcheng ejcheng requested a review from a team September 18, 2022 15:08
@ejcheng ejcheng self-assigned this Sep 18, 2022
@ejcheng ejcheng added c: feature Request for new feature p: 1-normal Nothing urgent m: finance Something is referring to the finance module labels Sep 18, 2022
@ejcheng ejcheng added this to the v7 - Current Major milestone Sep 18, 2022
@ejcheng ejcheng marked this pull request as ready for review September 18, 2022 15:10
@ejcheng ejcheng requested a review from a team as a code owner September 18, 2022 15:10
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 18, 2022

Codecov Report

Merging #1378 (3fcb070) into main (ea8d873) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1378   +/-   ##
=======================================
  Coverage   99.62%   99.63%           
=======================================
  Files        2163     2163           
  Lines      241264   241275   +11     
  Branches     1014     1018    +4     
=======================================
+ Hits       240357   240392   +35     
+ Misses        886      862   -24     
  Partials       21       21           
Impacted Files Coverage Δ
src/modules/finance/index.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 88.09% <0.00%> (+6.34%) ⬆️

Comment thread src/modules/finance/index.ts Outdated
Comment thread src/modules/finance/index.ts Outdated
@ejcheng ejcheng changed the title feat(finance): branchCode option in bic() feat(finance): branch code option in bic() Sep 19, 2022
@Shinigami92
Copy link
Copy Markdown
Member

Tests dont pass

Comment thread test/finance.spec.ts Outdated
@ST-DDT
Copy link
Copy Markdown
Member

ST-DDT commented Sep 20, 2022

Also: https://github.com/validatorjs/validator.js/blob/master/src/lib/isBIC.js

Comment thread src/modules/finance/index.ts Outdated
@ejcheng
Copy link
Copy Markdown
Member Author

ejcheng commented Sep 20, 2022

Seems like validator.isBIC does not recognize XK (Kosovo) as a country code, it intermittently fails when XK is the country code

@ejcheng ejcheng force-pushed the feat/branch_code_option branch from c8dc7d2 to 820aca1 Compare September 20, 2022 15:10
@ST-DDT
Copy link
Copy Markdown
Member

ST-DDT commented Sep 20, 2022

Seems like validator.isBIC does not recognize XK (Kosovo) as a country code, it intermittently fails when XK is the country code

Maybe report this to validatorjs for them to fix?

@ejcheng
Copy link
Copy Markdown
Member Author

ejcheng commented Sep 20, 2022

Seems like validator.isBIC does not recognize XK (Kosovo) as a country code, it intermittently fails when XK is the country code

Maybe report this to validatorjs for them to fix?

validatorjs/validator.js#2045

@ST-DDT ST-DDT merged commit fe97c29 into main Sep 22, 2022
@ST-DDT ST-DDT deleted the feat/branch_code_option branch September 22, 2022 16:27
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: feature Request for new feature m: finance Something is referring to the finance module p: 1-normal Nothing urgent

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Branch code option for SWIFT/BIC codes

3 participants