fix(locale): improve en_GB location addresses#1620
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1620 +/- ##
==========================================
+ Coverage 99.63% 99.64% +0.01%
==========================================
Files 2222 2227 +5
Lines 240133 240254 +121
Branches 1051 1055 +4
==========================================
+ Hits 239261 239406 +145
+ Misses 851 827 -24
Partials 21 21
|
Shinigami92
left a comment
There was a problem hiding this comment.
@matthewmayer You wrote
The default en locale uses quite Americanized street and city prefixes/suffixes
But there is no explanation why the new patterns are improvements (I'm a non-brithish person and don't have any kind of knowledge about streetnames in GB)
Beside my few comments, nothing blocking this PR from getting merged
just curious
|
There's just different historical context for the names Street numbers tend to be lower And new street names are often mandated to follow old patterns by local governments https://www.west-norfolk.gov.uk/info/20083/address_management/498/street_naming_conventions |
Improved addresses for en_GB locale. The default en locale uses quite Americanized street and city prefixes/suffixes
Examples in en_US
Examples in en_GB